From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: unused assignment in kvm_setup_pio() Date: Mon, 30 Jul 2007 16:57:35 +0300 Message-ID: <46ADEE4F.2030306@qumranet.com> References: <46ADED39.3040506@bull.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Laurent Vivier Return-path: In-Reply-To: <46ADED39.3040506-6ktuUTfB/bM@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Laurent Vivier wrote: > I think line 1809 of kvm_main.c (from git) is useless, isn't it ??? > > 1809 now = min(count, PAGE_SIZE / size); > 1810 > 1811 if (!down) > 1812 in_page = PAGE_SIZE - offset_in_page(address); > 1813 else > 1814 in_page = offset_in_page(address) + size; > 1815 now = min(count, (unsigned long)in_page / size); > 1816 if (!now) { > > Yes. I hate that code. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/