From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Add cpu consistence check in vmx. Date: Tue, 31 Jul 2007 11:10:14 +0300 Message-ID: <46AEEE66.9090806@qumranet.com> References: <46AEE63E.5020509@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Li, Xin B" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Li, Xin B wrote: >> btw, what about cpu hotplug? we need to deal with that too. Do we >> error out and refuse to enable the cpu if it isn't compatible enough? >> > > I think we shouldn't enable it, or the code becomes tooooo complex. > -xin > > What do you mean exactly? Don't enable cpu hotplug? it's needed for suspend/resume. Don't enable the cpu if it isn't compatible? I think that's the way to go. Don't enable feature compatibility checking on hotplug? -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/