[PATCH] Remove stat_set from debugfs

[PATCH] Remove stat_set from debugfs

[Rusty Russell]

We shouldn't define stat_set on the debug attributes, since that will
cause silent failure on writing: without a set argument, userspace
will get -EACCESS.

Signed-off-by: Rusty Russell <rusty-8n+1lVoiYb80n/F98K4Iww@public.gmane.org>

diff -r 968bc14f06fd drivers/kvm/kvm_main.c
--- a/drivers/kvm/kvm_main.c	Tue Jul 31 19:34:48 2007 +1000
+++ b/drivers/kvm/kvm_main.c	Tue Jul 31 19:36:33 2007 +1000
@@ -3009,11 +3009,7 @@ static u64 stat_get(void *_offset)
 	return total;
 }
 
-static void stat_set(void *offset, u64 val)
-{
-}
-
-DEFINE_SIMPLE_ATTRIBUTE(stat_fops, stat_get, stat_set, "%llu\n");
+DEFINE_SIMPLE_ATTRIBUTE(stat_fops, stat_get, NULL, "%llu\n");
 
 static __init void kvm_init_debug(void)
 {



-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: [PATCH] Remove stat_set from debugfs

[Avi Kivity]

Rusty Russell wrote:
> We shouldn't define stat_set on the debug attributes, since that will
> cause silent failure on writing: without a set argument, userspace
> will get -EACCESS.
>   

EAPPLIED, ETHANKS.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/