From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 2/2] Add MSR Bitmap support in VMX Date: Fri, 03 Aug 2007 17:54:10 +0300 Message-ID: <46B34192.9050909@qumranet.com> References: <37E52D09333DE2469A03574C88DBF40F048ED2@pdsmsx414.ccr.corp.intel.com> <46B1D092.7070609@qumranet.com> <1186091736.6131.149.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, "He, Qing" To: Rusty Russell Return-path: In-Reply-To: <1186091736.6131.149.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Rusty Russell wrote: >> Rusty, what say you to a 'struct page *module_to_page(void *kaddr)' >> which does the right thing? Attached an implementation. >> > > Hi Avi, > > Arch-specific, unfortunately: modules do not need to be allocated with > vmalloc (and for small modules probably shouldn't anyway). Luckily > vmalloc always page-aligns AFAICT, so you get that. > > So I think dynamic alloc is easier. > Rusty. > > Okay, we'll go with that. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/