Re: [PATCH 2/2] pio cleanup, split kvm_setup_pio() in two functions

[Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>]

[-- Attachment #1.1.1: Type: text/plain, Size: 811 bytes --]

Dong, Eddie wrote:
>>> I may confuse you. Currently master doesn't do in kernel PIO
>>> emulation, all string PIO will go to user level which is fine.  With
>>> lapic3, we have kernel PIO emulation for PIC. Linux doesn;t use
>>> string PIO for PIC (port 0x20/0x21) but XP and Win2003 does. So can
>>> u test kernel string PIO? 
>> Yes, I should be able, just explain me what and how...
>>
>> Laurent
> 
> Just check out both lapic3 user & kernel branch 
> (may need to rebase to master). And try to boot XP
> guest like you do for master. 
> thanks, eddie

BTW, could you apply this tiny patch to your branch...
(I don't like garbage in logs :-D )

Regards,
Laurent
-- 
------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org  --------------
          "Software is hard" - Donald Knuth

[-- Attachment #1.1.2: lapic3-printk --]
[-- Type: text/plain, Size: 651 bytes --]

Index: kvm/drivers/kvm/i8259.c
===================================================================
--- kvm.orig/drivers/kvm/i8259.c	2007-08-03 17:00:23.000000000 +0200
+++ kvm/drivers/kvm/i8259.c	2007-08-03 17:01:10.000000000 +0200
@@ -218,10 +218,10 @@
 			s->init_state = 1;
 			s->init4 = val & 1;
 			if (val & 0x02)
-				printk(KERN_ERR "single mode not supported");
+				printk(KERN_ERR "single mode not supported\n");
 			if (val & 0x08)
 				printk(KERN_ERR
-				       "level sensitive irq not supported");
+				       "level sensitive irq not supported\n");
 		} else if (val & 0x08) {
 			if (val & 0x04)
 				s->poll = 1;

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel