From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Vivier Subject: Re: [PATCH 2/2] pio cleanup, split kvm_setup_pio() in two functions Date: Fri, 03 Aug 2007 17:13:21 +0200 Message-ID: <46B34611.7030800@bull.net> References: <10EA09EFD8728347A513008B6B0DA77A01E00844@pdsmsx411.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0405378088==" Cc: kvm-devel To: "Dong, Eddie" Return-path: In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A01E00844-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============0405378088== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig4AB5DFE02337A9E381FE248B" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig4AB5DFE02337A9E381FE248B Content-Type: multipart/mixed; boundary="------------060406020304050805090604" This is a multi-part message in MIME format. --------------060406020304050805090604 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Dong, Eddie wrote: >>> I may confuse you. Currently master doesn't do in kernel PIO >>> emulation, all string PIO will go to user level which is fine. With >>> lapic3, we have kernel PIO emulation for PIC. Linux doesn;t use >>> string PIO for PIC (port 0x20/0x21) but XP and Win2003 does. So can >>> u test kernel string PIO?=20 >> Yes, I should be able, just explain me what and how... >> >> Laurent >=20 > Just check out both lapic3 user & kernel branch=20 > (may need to rebase to master). And try to boot XP > guest like you do for master.=20 > thanks, eddie BTW, could you apply this tiny patch to your branch... (I don't like garbage in logs :-D ) Regards, Laurent --=20 ------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org -------------- "Software is hard" - Donald Knuth --------------060406020304050805090604 Content-Type: text/plain; name="lapic3-printk" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline; filename="lapic3-printk" Index: kvm/drivers/kvm/i8259.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- kvm.orig/drivers/kvm/i8259.c 2007-08-03 17:00:23.000000000 +0200 +++ kvm/drivers/kvm/i8259.c 2007-08-03 17:01:10.000000000 +0200 @@ -218,10 +218,10 @@ s->init_state =3D 1; s->init4 =3D val & 1; if (val & 0x02) - printk(KERN_ERR "single mode not supported"); + printk(KERN_ERR "single mode not supported\n"); if (val & 0x08) printk(KERN_ERR - "level sensitive irq not supported"); + "level sensitive irq not supported\n"); } else if (val & 0x08) { if (val & 0x04) s->poll =3D 1; --------------060406020304050805090604-- --------------enig4AB5DFE02337A9E381FE248B Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.7 (GNU/Linux) iD8DBQFGs0YV9Kffa9pFVzwRAhxtAKChLREI1nZdWgB+1zncPebsvUIy0wCfScQ9 hMg9AyfuhFkIajgxDjSqzNc= =v5cu -----END PGP SIGNATURE----- --------------enig4AB5DFE02337A9E381FE248B-- --===============0405378088== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ --===============0405378088== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --===============0405378088==--