From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: k->u migration bug fix Date: Mon, 06 Aug 2007 16:25:42 +0300 Message-ID: <46B72156.8010209@qumranet.com> References: <10EA09EFD8728347A513008B6B0DA77A01E00BA4@pdsmsx411.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: "Dong, Eddie" Return-path: In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A01E00BA4-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Dong, Eddie wrote: > Fix bug for wrong vcpu->apic due to irq_summary set in user irqchip > which makes union member vcpu->apic non NULL. > > Signed-off-by: Yaozu (Eddie) Dong > > diff --git a/drivers/kvm/kvm_main.c b/drivers/kvm/kvm_main.c > index 470b7a1..03c1433 100644 > --- a/drivers/kvm/kvm_main.c > +++ b/drivers/kvm/kvm_main.c > @@ -1068,7 +1068,7 @@ static struct kvm_io_device > *vcpu_find_pervcpu_dev(struct > { > struct kvm_io_device *dev; > > - if (vcpu->apic) { > + if (irqchip_in_kernel(vcpu->kvm) && vcpu->apic) { > dev = &vcpu->apic->dev; > if (dev->in_range(dev, addr)) > return dev; > Applied. Please don't forget to send an attachment, I had to apply this by hand. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/