public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
To: "Jorge Lucángeli Obes" <t4m5yn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: Storing command line options in qcow2 images
Date: Mon, 06 Aug 2007 15:13:26 -0500	[thread overview]
Message-ID: <46B780E6.8050305@codemonkey.ws> (raw)
In-Reply-To: <59abf66e0707292040j11c8b981mf7f793258e874400-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

I don't think adding annotations as snapshots is the right approach.  I 
think proper support should be added in the header.  I wouldn't be too 
concerned with breaking compatibility in qcow2.  That's why it's qcow2 
and not just an updated version of qcow, qcow2 is still, AFAIK, open for 
breakage.

Regards,

Anthony Liguori

Jorge Lucángeli Obes wrote:
> Hi Avi, hi all,
>
> I've started some (very minor) groundwork for this task. My idea was
> to add an extra "annotation" field in qcow2 snapshots. In this way, a
> snapshot can hold abitrary information; for example, command line
> arguments.
>
> Before going any further, I wanted to validate the general idea with
> the list. I am planning on using a snapshot with a distinct name to
> store command line options. This approach seems simple yet it is
> powerful enough for what we need to do.
>
> There's a slight overhead as now all qcow2 snapshots have to store a
> extra (probably) empty pointer. An alternative approach would be to
> somehow indicate that some snapshots are "descriptive" snapshots and
> others are "useful" snapshots; however, I felt that this would be more
> complicated.
>
> I have a working patch to qemu-img that allows storing arbitrary
> annotations into qcow2 images. I developed it as a testing utility.
> Right now annotations are implemented as another string alongside the
> snapshot's 'name' and 'id'. I thought about storing annotations as
> key/value pairs but again, it seemed overkill.
>
> >From here, the plan would be to add a command to qemu-img that allows
> embedding of command line options into qcow2 images. These options
> would be stored in a snapshot with a special name, and qemu would
> check for the presence of this snapshot in order to read command line
> options from the qcow2 image.
>
> Ideas? Suggestions? I can send the patches for the functionality
> that's implemented right now.
>
> Cheers,
> Jorge
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >>  http://get.splunk.com/
> _______________________________________________
> kvm-devel mailing list
> kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
>
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

  parent reply	other threads:[~2007-08-06 20:13 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-30  3:40 Storing command line options in qcow2 images Jorge Lucángeli Obes
     [not found] ` <59abf66e0707292040j11c8b981mf7f793258e874400-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-07-30  8:36   ` Avi Kivity
     [not found]     ` <46ADA303.9060504-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-31  2:35       ` Jorge Lucángeli Obes
     [not found]         ` <59abf66e0707301935t12c13db1pbd9026b978e70b7d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-07-31  7:00           ` Laurent Vivier
2007-08-01  8:50   ` Andrew Walrond
     [not found]     ` <46B04970.3050103-2/QedQ4M3FBAfugRpC6u6w@public.gmane.org>
2007-08-02 10:54       ` Avi Kivity
2007-08-06 20:13   ` Anthony Liguori [this message]
     [not found]     ` <46B780E6.8050305-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-08-06 23:31       ` Jorge Lucángeli Obes
2007-08-07  4:10       ` Avi Kivity
     [not found]         ` <46B7F0A9.9060505-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-07 13:50           ` Daniel P. Berrange
     [not found]             ` <20070807135029.GA20274-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-08-08  0:15               ` Avi Kivity
     [not found]                 ` <46B90B16.7020604-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-08  0:36                   ` Anthony Liguori
     [not found]                     ` <46B91019.1020009-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-08-09 14:32                       ` Avi Kivity
2007-08-08 18:02           ` Anthony Liguori
     [not found]             ` <46BA054B.1050201-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-08-08 18:21               ` Jorge Lucángeli Obes
2007-08-09 14:54               ` Laurent Vivier
2007-08-09 20:04               ` Avi Kivity

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46B780E6.8050305@codemonkey.ws \
    --to=anthony-rdkfgonbjusknkdkm+me6a@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=t4m5yn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox