From: Carsten Otte <cotte-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
To: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org"
<kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org>,
mp3-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org,
borntrae-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org
Subject: Re: [patch] cleanup struct kvm_vcpu control registers
Date: Wed, 08 Aug 2007 18:29:26 +0200 [thread overview]
Message-ID: <46B9EF66.30708@de.ibm.com> (raw)
In-Reply-To: <46B9D250.9020906-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Avi Kivity wrote:
> I don't think we should aim for keeping control registers in an arch
> independent manner, since there is nothing common among the different
> architectures in that area. For x86, keeping them in an array is not
> helpful since the individual control registers have nothing to do with
> each other. Also, for most things like the fpu and segment registers
> this trick won't work.
>
> I suggest keeping them in an arch dependent structure (struct
> kvm_vcpu_arch) in <asm/kvm.h>. We can then access them through a member
> as vcpu->arch.cr0, etc.
Fine with me, I gonna patch that direction.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
prev parent reply other threads:[~2007-08-08 16:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-08 12:26 [patch] cleanup struct kvm_vcpu control registers Carsten Otte
[not found] ` <1186575977.7019.11.camel-WIxn4w2hgUz3YA32ykw5MLlKpX0K8NHHQQ4Iyu8u01E@public.gmane.org>
2007-08-08 14:25 ` Avi Kivity
[not found] ` <46B9D250.9020906-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-08 16:29 ` Carsten Otte [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46B9EF66.30708@de.ibm.com \
--to=cotte-ta70fqpds9bqt0dzr+alfa@public.gmane.org \
--cc=avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=borntrae-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
--cc=carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
--cc=mp3-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox