From mboxrd@z Thu Jan 1 00:00:00 1970 From: Carsten Otte Subject: Re: [patch] cleanup struct kvm_vcpu control registers Date: Wed, 08 Aug 2007 18:29:26 +0200 Message-ID: <46B9EF66.30708@de.ibm.com> References: <1186575977.7019.11.camel@cotte.boeblingen.de.ibm.com> <46B9D250.9020906@qumranet.com> Reply-To: carsteno-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: "kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org" , mp3-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org, borntrae-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org To: Avi Kivity Return-path: In-Reply-To: <46B9D250.9020906-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > I don't think we should aim for keeping control registers in an arch > independent manner, since there is nothing common among the different > architectures in that area. For x86, keeping them in an array is not > helpful since the individual control registers have nothing to do with > each other. Also, for most things like the fpu and segment registers > this trick won't work. > > I suggest keeping them in an arch dependent structure (struct > kvm_vcpu_arch) in . We can then access them through a member > as vcpu->arch.cr0, etc. Fine with me, I gonna patch that direction. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/