Re: Storing command line options in qcow2 images

[Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>]

[-- Attachment #1.1: Type: text/plain, Size: 1604 bytes --]

Anthony Liguori wrote:
> Avi Kivity wrote:
>> Anthony Liguori wrote:
>>   
>>> I don't think adding annotations as snapshots is the right approach.  I 
>>> think proper support should be added in the header.  I wouldn't be too 
>>> concerned with breaking compatibility in qcow2.  That's why it's qcow2 
>>> and not just an updated version of qcow, qcow2 is still, AFAIK, open for 
>>> breakage.
>>>   
>>>     
>> Are all the users' images open for breakage too?
>>   
> 
> FWIW, you can extended the header without causing a breakage.  Just bump 
> the version, add the field, and add appropriate code.  Of course, this 
> is technically qcow v3 but it's a good opportunity to make things a bit 
> sanier such that instead of check version == QCOW_VERSION that version 
>  >= QCOW_VERSION.

It's funny, we had the same kind of discussion about ext3/ext4 some months ago...

The problem with changing qcow version is you prevent people using unmodified
version of qemu to use this disk image.

IMHO, I think the best thing to do is to introduce the command line option in
empty snapshot in current version of qcow2 (so an unmodified version of qemu is
able to use the image, ignoring the command line, and a modified version can use
this new feature). And then, after, thinking about QCOW3 we can define a set of
new functionalities we want to introduce and add "command line in qcow header"
in this set of functionalities.

Regards,
Laurent
-- 
------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org  --------------
          "Software is hard" - Donald Knuth


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel