From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Vivier Subject: Re: Storing command line options in qcow2 images Date: Thu, 09 Aug 2007 16:54:57 +0200 Message-ID: <46BB2AC1.3050403@bull.net> References: <59abf66e0707292040j11c8b981mf7f793258e874400@mail.gmail.com> <46B780E6.8050305@codemonkey.ws> <46B7F0A9.9060505@qumranet.com> <46BA054B.1050201@codemonkey.ws> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============0463587262==" Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Anthony Liguori Return-path: In-Reply-To: <46BA054B.1050201-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============0463587262== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigEF733B5D762E90196246CB3C" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigEF733B5D762E90196246CB3C Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Anthony Liguori wrote: > Avi Kivity wrote: >> Anthony Liguori wrote: >> =20 >>> I don't think adding annotations as snapshots is the right approach. = I=20 >>> think proper support should be added in the header. I wouldn't be to= o=20 >>> concerned with breaking compatibility in qcow2. That's why it's qcow= 2=20 >>> and not just an updated version of qcow, qcow2 is still, AFAIK, open = for=20 >>> breakage. >>> =20 >>> =20 >> Are all the users' images open for breakage too? >> =20 >=20 > FWIW, you can extended the header without causing a breakage. Just bum= p=20 > the version, add the field, and add appropriate code. Of course, this = > is technically qcow v3 but it's a good opportunity to make things a bit= =20 > sanier such that instead of check version =3D=3D QCOW_VERSION that vers= ion=20 > >=3D QCOW_VERSION. It's funny, we had the same kind of discussion about ext3/ext4 some month= s ago... The problem with changing qcow version is you prevent people using unmodi= fied version of qemu to use this disk image. IMHO, I think the best thing to do is to introduce the command line optio= n in empty snapshot in current version of qcow2 (so an unmodified version of q= emu is able to use the image, ignoring the command line, and a modified version = can use this new feature). And then, after, thinking about QCOW3 we can define a = set of new functionalities we want to introduce and add "command line in qcow he= ader" in this set of functionalities. Regards, Laurent --=20 ------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org -------------- "Software is hard" - Donald Knuth --------------enigEF733B5D762E90196246CB3C Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.7 (GNU/Linux) iD8DBQFGuyrE9Kffa9pFVzwRArN+AKCMOz5BijhkSS2AmnAt00oBqaHmcwCfdRKQ /foSYgk9e7rkjyjlWrvVbVg= =FEyt -----END PGP SIGNATURE----- --------------enigEF733B5D762E90196246CB3C-- --===============0463587262== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ --===============0463587262== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --===============0463587262==--