public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
To: Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: Storing command line options in qcow2 images
Date: Thu, 09 Aug 2007 23:04:31 +0300	[thread overview]
Message-ID: <46BB734F.1070100@qumranet.com> (raw)
In-Reply-To: <46BA054B.1050201-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>

Anthony Liguori wrote:
> Avi Kivity wrote:
>> Anthony Liguori wrote:
>>  
>>> I don't think adding annotations as snapshots is the right 
>>> approach.  I think proper support should be added in the header.  I 
>>> wouldn't be too concerned with breaking compatibility in qcow2.  
>>> That's why it's qcow2 and not just an updated version of qcow, qcow2 
>>> is still, AFAIK, open for breakage.
>>>       
>>
>> Are all the users' images open for breakage too?
>>   
>
> FWIW, you can extended the header without causing a breakage.  Just 
> bump the version, add the field, and add appropriate code.  Of course, 
> this is technically qcow v3 but it's a good opportunity to make things 
> a bit sanier such that instead of check version == QCOW_VERSION that 
> version >= QCOW_VERSION.
>

This sounds much better.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

      parent reply	other threads:[~2007-08-09 20:04 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-30  3:40 Storing command line options in qcow2 images Jorge Lucángeli Obes
     [not found] ` <59abf66e0707292040j11c8b981mf7f793258e874400-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-07-30  8:36   ` Avi Kivity
     [not found]     ` <46ADA303.9060504-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-07-31  2:35       ` Jorge Lucángeli Obes
     [not found]         ` <59abf66e0707301935t12c13db1pbd9026b978e70b7d-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-07-31  7:00           ` Laurent Vivier
2007-08-01  8:50   ` Andrew Walrond
     [not found]     ` <46B04970.3050103-2/QedQ4M3FBAfugRpC6u6w@public.gmane.org>
2007-08-02 10:54       ` Avi Kivity
2007-08-06 20:13   ` Anthony Liguori
     [not found]     ` <46B780E6.8050305-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-08-06 23:31       ` Jorge Lucángeli Obes
2007-08-07  4:10       ` Avi Kivity
     [not found]         ` <46B7F0A9.9060505-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-07 13:50           ` Daniel P. Berrange
     [not found]             ` <20070807135029.GA20274-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
2007-08-08  0:15               ` Avi Kivity
     [not found]                 ` <46B90B16.7020604-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-08  0:36                   ` Anthony Liguori
     [not found]                     ` <46B91019.1020009-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-08-09 14:32                       ` Avi Kivity
2007-08-08 18:02           ` Anthony Liguori
     [not found]             ` <46BA054B.1050201-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-08-08 18:21               ` Jorge Lucángeli Obes
2007-08-09 14:54               ` Laurent Vivier
2007-08-09 20:04               ` Avi Kivity [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46BB734F.1070100@qumranet.com \
    --to=avi-atkuwr5tajbwk0htik3j/w@public.gmane.org \
    --cc=anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox