From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Storing command line options in qcow2 images Date: Thu, 09 Aug 2007 23:04:31 +0300 Message-ID: <46BB734F.1070100@qumranet.com> References: <59abf66e0707292040j11c8b981mf7f793258e874400@mail.gmail.com> <46B780E6.8050305@codemonkey.ws> <46B7F0A9.9060505@qumranet.com> <46BA054B.1050201@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Anthony Liguori Return-path: In-Reply-To: <46BA054B.1050201-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > Avi Kivity wrote: >> Anthony Liguori wrote: >> >>> I don't think adding annotations as snapshots is the right >>> approach. I think proper support should be added in the header. I >>> wouldn't be too concerned with breaking compatibility in qcow2. >>> That's why it's qcow2 and not just an updated version of qcow, qcow2 >>> is still, AFAIK, open for breakage. >>> >> >> Are all the users' images open for breakage too? >> > > FWIW, you can extended the header without causing a breakage. Just > bump the version, add the field, and add appropriate code. Of course, > this is technically qcow v3 but it's a good opportunity to make things > a bit sanier such that instead of check version == QCOW_VERSION that > version >= QCOW_VERSION. > This sounds much better. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/