public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
To: "Jorge Lucángeli Obes" <t4m5yn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org
Subject: Re: Storing command line options in images
Date: Fri, 10 Aug 2007 11:02:32 -0500	[thread overview]
Message-ID: <46BC8C18.6020108@codemonkey.ws> (raw)
In-Reply-To: <59abf66e0708092155t2e3cd5o32f23c018bed65af-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

Jorge Lucángeli Obes wrote:
> Hi all,
>
> >From what I've gathered, it seems that we have basically four options
> at hand. I think it's important to notice, however, that whatever
> comes out of this will probably be, as Avi said, a "low-end" solution.
> IMHO there's room to have both the high-end libvirt-like approach, and
> the "shell replacer" approach.
>
> So let's see:
>
> 1- We could go the way of the patches I've posted, adding the comments
> everyone's made.
> 1a- It's a good idea to actively signal QEMU to read command line
> options from the image file, and not have it on by default.
>   

I think if you have to add a new option, the base implementation is 
wrong.  The whole point of this is to simplify things for the user and 
adding more weird options just makes things more complicated.

> 1b- As Avi said, there are many guest-related options that would be
> good to store _somewhere_. The user always has the option of using
> qemu-img to review the options that the VM is going to use. I think
> that having a "valid" set of options that the user can store will
> complicate things too much.
>
> 2- We could bump qcow's version number and add command line options as
> "first-class citizens" of the image world.
> 2a- As Anthony suggested, it could be a good starting point to make
> sure these version transition happen in a smoother way.
>
> 3- We could add command line options as plain text in the image
> itself. Sounds (to me) risky and not very user friendly.
>   

Why is it risky or user unfriendly?  From the user's perspective, it's 
no different from storing it in a snapshot.  The user still needs a 
separate tool (qemu-img) to view and manipulate the command line.  The 
only real user facing difference is that the image itself is now 
directly executable.  This turns out to be a Good Thing in that the user 
is now aware that he must trust that image which addresses the concern 
in 1a.

> 4- We could have configuration files associated with the host and guests.
> 4a- Embedded XML.
> 4b- Separate files.
>   

This is a big effort but a config file is the right long term solution.

Regards,

Anthony Liguori

> What do you guys think? I'm partial to 1 or 2. Since the beginning my
> approach was that of a simple solution for a simple feature.
>
> Cheers,
> Jorge
>
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >>  http://get.splunk.com/
> _______________________________________________
> kvm-devel mailing list
> kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/kvm-devel
>
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

  parent reply	other threads:[~2007-08-10 16:02 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-10  4:55 Storing command line options in images Jorge Lucángeli Obes
     [not found] ` <59abf66e0708092155t2e3cd5o32f23c018bed65af-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-10 16:02   ` Anthony Liguori [this message]
     [not found]     ` <46BC8C18.6020108-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-08-10 17:14       ` [Qemu-devel] " Avi Kivity
     [not found]         ` <46BC9CDB.3080900-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-10 18:43           ` Anthony Liguori
     [not found]             ` <46BCB1DA.6060102-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-08-10 19:41               ` Avi Kivity
     [not found]                 ` <46BCBF73.5060406-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-10 20:11                   ` Anthony Liguori
     [not found]                     ` <46BCC666.6050406-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-08-11  1:41                       ` Jorge Lucángeli Obes
     [not found]                         ` <59abf66e0708101841i76e26a35vcbc8df14b21f1ac0-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-13  8:55                           ` Avi Kivity
     [not found]                             ` <46C01C8D.3060304-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-13  9:19                               ` Laurent Vivier
2007-08-13  9:27                                 ` [kvm-devel] " Christian MICHON
2007-08-14 14:18                                 ` Markus Hitter
     [not found]                                   ` <F213D784-7927-4233-BD3E-57A808D31FE7-5aU9hSJ5JWgb1SvskN2V4Q@public.gmane.org>
2007-08-14 14:31                                     ` [Qemu-devel] " Laurent Vivier
     [not found]                                       ` <46C1BCAC.9030203-6ktuUTfB/bM@public.gmane.org>
2007-08-14 19:02                                         ` Jorge Lucángeli Obes
     [not found]                                           ` <59abf66e0708141202t4eaf009cs4596cc76a164e3de-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-14 20:07                                             ` Thiemo Seufer
     [not found]                                               ` <20070814200757.GA7685-eH4hzgmiRX8dwXzzRB9H2Q@public.gmane.org>
2007-08-14 20:46                                                 ` Christian MICHON
2007-08-13 19:39                         ` [kvm-devel] " Thiemo Seufer
     [not found]                           ` <20070813193927.GA21215-eH4hzgmiRX8dwXzzRB9H2Q@public.gmane.org>
2007-08-13 20:26                             ` [Qemu-devel] " Christian MICHON
2007-08-14  3:17                             ` Anthony Liguori
2007-08-14  4:39                               ` Jorge Lucángeli Obes
2007-08-14  7:46                           ` [kvm-devel] " Laurent Vivier
     [not found]                             ` <46C15DCE.1000205-6ktuUTfB/bM@public.gmane.org>
2007-08-15 21:26                               ` [Qemu-devel] " Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46BC8C18.6020108@codemonkey.ws \
    --to=anthony-rdkfgonbjusknkdkm+me6a@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=qemu-devel-qX2TKyscuCcdnm+yROfE0A@public.gmane.org \
    --cc=t4m5yn-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox