public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Anthony Liguori <anthony-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
To: Gregory Haskins <ghaskins-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: help with understanding GPA/GVA issues
Date: Fri, 10 Aug 2007 15:12:50 -0500	[thread overview]
Message-ID: <46BCC6C2.1060002@codemonkey.ws> (raw)
In-Reply-To: <1186775254.4866.52.camel-5CR4LY5GPkvLDviKLk5550HKjMygAv58XqFh9Ls21Oc@public.gmane.org>

Gregory Haskins wrote:
> On Fri, 2007-08-10 at 19:59 +0300, Avi Kivity wrote:
>
>   
>> Note that passing a virtual address is highly discouraged as its meaning 
>> can change from vcpu to vcpu, it might not be mapped, translation is 
>> slow, etc.  Just let the guest do the translation.
>>     
>
> Yeah, Hollis and Anthony straighted me out via IRC.  I will mostly be
> dealing with kmalloc/skb buffers so we settled on the following as
> optimal:
>
> guest-side
>
> gpa = __pa(ptr);
>
> host-side:
>
> gfn  = gpa >> PAGE_SHIFT
> page = gfn_to_page(gfn);
> ptr = kmap(page);
>
> ..
>
> kunmap(ptr); 
>   

kmap can sleep so you often have to use kmap_atomic in KVM.  Although, 
I'm not sure if the pre-emption notification means that no longer is the 
case.

Regards,

Anthony Liguori

>   
>> We have something running at qumranet, will be sent out soon.  I am 
>> somewhat discouraged in trying to get the thing to page -- Shaohua's 
>> approach is much simpler.
>>
>>     
>
> Cool!  Ill keep an eye out.
>
> -Greg
>
>
>   


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

  parent reply	other threads:[~2007-08-10 20:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-10  4:09 help with understanding GPA/GVA issues Gregory Haskins
     [not found] ` <1186718958.4866.15.camel-5CR4LY5GPkvLDviKLk5550HKjMygAv58XqFh9Ls21Oc@public.gmane.org>
2007-08-10 14:32   ` Anthony Liguori
     [not found]     ` <46BC7709.4030807-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org>
2007-08-10 14:40       ` Gregory Haskins
     [not found]         ` <1186756859.4866.31.camel-5CR4LY5GPkvLDviKLk5550HKjMygAv58XqFh9Ls21Oc@public.gmane.org>
2007-08-10 16:59           ` Avi Kivity
     [not found]             ` <46BC9978.3060801-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-10 19:47               ` Gregory Haskins
     [not found]                 ` <1186775254.4866.52.camel-5CR4LY5GPkvLDviKLk5550HKjMygAv58XqFh9Ls21Oc@public.gmane.org>
2007-08-10 20:12                   ` Anthony Liguori [this message]
2007-08-10 15:16 ` Hollis Blanchard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46BCC6C2.1060002@codemonkey.ws \
    --to=anthony-rdkfgonbjusknkdkm+me6a@public.gmane.org \
    --cc=ghaskins-Et1tbQHTxzrQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox