public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] qemu: free migration structure if migration fails
@ 2007-08-10 19:31 Jim Paris
       [not found] ` <11867742993220-git-send-email-jim-XrPbb/hENzg@public.gmane.org>
  0 siblings, 1 reply; 2+ messages in thread
From: Jim Paris @ 2007-08-10 19:31 UTC (permalink / raw)
  To: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f; +Cc: Jim Paris

Without this, memory is leaked and later attempts fail with
"Migration already active".

Signed-off-by: Jim Paris <jim-XrPbb/hENzg@public.gmane.org>
---
 qemu/migration.c |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/qemu/migration.c b/qemu/migration.c
index bbeed86..ed1fd29 100644
--- a/qemu/migration.c
+++ b/qemu/migration.c
@@ -190,6 +190,8 @@ static void migrate_finish(MigrationState *s)
         save_verify_memory(f, NULL);
 #endif /* MIGRATION_VERIFY */
         qemu_fclose(f);
+    } else {
+	    migrate_close(s);
     }
     status = *has_error;
     if (ret && !status)
-- 
1.5.3.rc4


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

^ permalink raw reply related	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2007-08-13  8:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-08-10 19:31 [PATCH] qemu: free migration structure if migration fails Jim Paris
     [not found] ` <11867742993220-git-send-email-jim-XrPbb/hENzg@public.gmane.org>
2007-08-13  8:02   ` Avi Kivity

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox