From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Fix network boot whether KVM is enabled or disabled Date: Mon, 13 Aug 2007 11:07:08 +0300 Message-ID: <46C0112C.6020707@qumranet.com> References: <135cb3c30708101552j6ed4433et5c18f2dfae9cce6d@mail.gmail.com> <46BD2455.2040204@codemonkey.ws> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, Chuan-kai Lin To: Anthony Liguori Return-path: In-Reply-To: <46BD2455.2040204-rdkfGonbjUSkNkDKm+mE6A@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Anthony Liguori wrote: > Chuan-kai Lin wrote: > >> From: Chuan-kai Lin >> >> This patch is based on the one Anthony Liguori submitted to kvm-devel >> on July 2nd, which fixes PXE booting with KVM enabled but breaks PXE >> booting when not using KVM. I simplified Anthony's patch and >> duplicated the cpu_register_physical_memory call to ensure that the >> code retains its original behavior when kvm_allowed is 0. >> > Should be: > > } else > [other indentation errors there too] > I clearly preferred the way I did it but I don't care that much. Thanks > for bringing this patch up again, I've been meaning to resubmit it. > > I must have missed or forgotten about that earlier patch, sorry. If you think your patch is better, please send it. While we want to encourage newcomers we also want the best patches... -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/