From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Patch] (big) real mode emulation - jmp rel Date: Mon, 13 Aug 2007 11:49:18 +0300 Message-ID: <46C01B0E.7080304@qumranet.com> References: <1186785157.6097.19.camel@lnitindesktop.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , "Yu, Wilfred" To: nitin.a.kamble-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <1186785157.6097.19.camel-mpPvwfgnXtFHIUuj5cj4Omt3HXsI98Cx0E9HWUfgJXw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Nitin A Kamble wrote: > Hi Avi, > The patch to implement "jmp rel" emulation is attached. > > +#define jmp_rel(rel) \ > +do { \ > + _eip += (int)(rel); \ > + _eip = ((op_bytes == 2) ? (uint16_t)_eip : (uint32_t)_eip); \ > +} while (0) > + Please use an inline function instead of a macro. That will help when we later make large scale changes (for example, splitting the emulator into a decoder and executor). (and, when defining the macro, indent the contents) -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/