Re: [Patch] (big) real mode emulation - jmp rel

Avi Kivity
2007-08-13T08:49:18Z

Nitin A Kamble wrote:
> Hi Avi,
> The patch to implement "jmp rel" emulation is attached.

>
> +#define jmp_rel(rel) \
> +do { \
> + _eip += (int)(rel); \
> + _eip = ((op_bytes == 2) ? (uint16_t)_eip : (uint32_t)_eip); \
> +} while (0)
> +

Please use an inline function instead of a macro. That will help when
we later make large scale changes (for example, splitting the emulator
into a decoder and executor).

(and, when defining the macro, indent the contents)

--
error compiling committee.c: too many arguments to function