Re: [Patch] (big) real mode emulation - jmp rel

Nitin A Kamble
2007-08-16T20:34:29Z

[-- Attachment #1.1: Type: text/plain, Size: 769 bytes --]

Avi,
In my opinion converting this small function to file-scope function,
would make code look ugly. I think the earlier Macro definition was
better.

On Thu, 2007-08-16 at 03:25 -0700, Avi Kivity wrote:
> > + inline void jmp_rel(int rel)
> > + {
> > + _eip += (int)(rel);
> > + _eip = ((op_bytes == 2) ? (uint16_t)_eip :
> (uint32_t)_eip);
> > + };
> > +
>
> This is a nested function which we don't use (in the kernel or
> userspace).
>
> It needs to be a file-scope function (static, too).

--
Thanks & Regards,
Nitin
Open Source Technology Center, Intel Corporation
-----------------------------------------------------------------
The mind is like a parachute; it works much better when it's open