Re: add back pending timer irqs for kernel APIC timer

Dong, Eddie
2007-08-13T13:31:33Z

>> kvm_pt_update_irq is within intr_assist where host IRQ is disabled.
>> It can be updated only after we return to guest.
>>
>
> What if it runs on another cpu?

This case will be forbidden in next patch. We need to remove apic->lock
too.

>
>>>>
>>> How about "kvm_inject_pending_timer_irqs"
>>>
>>
>> Sure. But we will have PIT too, so maybe kvm_inject_apic_timer_irqs?
>>
>>
>
> Maybe kvm_inject_pending_timer_irqs() can call the apic and pit
> variants, so we have just on hook in vmx.c and svm.c?

No problem.

>
>>
>> BTW, can u rebase the branch? I saw some error in today's branch.
>>
>> Will send patch after you rebased.
>>
>
> Okay. I am testing out kvm-34 now, will start rebase shortly after.
> It will take some time as there have been quite a few changes.
>
>
OK, so you pull in a lot today?