From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: add back pending timer irqs for kernel APIC timer Date: Mon, 13 Aug 2007 16:38:04 +0300 Message-ID: <46C05EBC.8000808@qumranet.com> References: <10EA09EFD8728347A513008B6B0DA77A01E8DA94@pdsmsx411.ccr.corp.intel.com><10EA09EFD8728347A513008B6B0DA77A01E8DA9B@pdsmsx411.ccr.corp.intel.com><46C03EA6.7030709@qumranet.com><10EA09EFD8728347A513008B6B0DA77A014E8AD0@pdsmsx411.ccr.corp.intel.com><46C05BE0.4060908@qumranet.com> <10EA09EFD8728347A513008B6B0DA77A014E8AD3@pdsmsx411.ccr.corp.intel.com> <10EA09EFD8728347A513008B6B0DA77A014E8AD4@pdsmsx411.ccr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: "Dong, Eddie" Return-path: In-Reply-To: <10EA09EFD8728347A513008B6B0DA77A014E8AD4-wq7ZOvIWXbNpB2pF5aRoyrfspsVTdybXVpNB7YpNyf8@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Dong, Eddie wrote: > kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org wrote: > >>>> kvm_pt_update_irq is within intr_assist where host IRQ is disabled. >>>> It can be updated only after we return to guest. >>>> >>>> >>> What if it runs on another cpu? >>> >> This case will be forbidden in next patch. We need to remove >> apic->lock too. >> >> > To avoid confuse, I mean hrtimer will be migrated as guest migrated. > Ah okay. Makes sense, and we have the hooks for it already in vcpu_load. > And stop hrtimer when it is not in guest mode. > I'm not convinced this is important. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/