public inbox for kvm@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Vivier <Laurent.Vivier-6ktuUTfB/bM@public.gmane.org>
To: Christian Borntraeger
	<borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org,
	linux-kernel
	<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH 0/2][KVM] guest time accounting
Date: Mon, 13 Aug 2007 16:22:50 +0200	[thread overview]
Message-ID: <46C0693A.1080900@bull.net> (raw)
In-Reply-To: <200708131605.40479.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>


[-- Attachment #1.1: Type: text/plain, Size: 1784 bytes --]

Christian Borntraeger wrote:
> Am Freitag, 10. August 2007 schrieb Laurent Vivier:
>> The aim of these two patches is to measure the CPU time used by a virtual
>> machine. All comments are welcome... I'm not sure it's the good way to do 
> that.
> 
> I did something similar for or s390guest prototype, that Carsten posted in 
> May.  I decided to account guest time to the user process instead of adding a 
> new field to avoid hazzle with old top. As you can read in the patch comment, 
> I personally prefer a new field if we can get one.
> 
> My implementation uses a similar mechanism like hard and softirq. So I have an 
> sie_enter an sie_exit and a task_is_in_sie function - like irq_enter and 
> irq_exit. The main difference is based on the fact, that s390 has precise 
> accouting for irq, steal, user and system time, and therefore my patch is 
> based on architecture specifc code using CONFIG_VIRT_CPU_ACCOUNT. 
> 
> In general my patch has the same idea as your patch, so I am going to review 
> your patch and see if it would fit for s390.
> 
> For reference this is the (never posted) old patch for our virtualisation 
> prototype. It wont work with kvm but it gives you the idea what we had in 
> mind on s390.
> 

thank you for your comment.

As virtualization becomes very popular, perhaps we should implement something
which could be used by all linux supported architectures ?
(yes, I know it's non-sense for archs like m68k...)
But my [PATCH 1/2] can be a good start (adding "guest" in cpustat)
As guest accounting is hw dependent, I think we should add a hook in the
accounting functions.

Laurent
-- 
------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org  --------------
          "Software is hard" - Donald Knuth


[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

  parent reply	other threads:[~2007-08-13 14:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-08-10 15:58 [PATCH 0/2][KVM] guest time accounting Laurent Vivier
     [not found] ` <46BC8B39.6050202-6ktuUTfB/bM@public.gmane.org>
2007-08-13  8:01   ` Avi Kivity
     [not found]     ` <46C00FC1.1070306-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-13  8:13       ` Laurent Vivier
     [not found]         ` <46C012A8.2040908-6ktuUTfB/bM@public.gmane.org>
2007-08-13  8:38           ` Avi Kivity
     [not found]             ` <46C01877.7060007-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-13 13:08               ` Laurent Vivier
     [not found]                 ` <46C057C0.7020003-6ktuUTfB/bM@public.gmane.org>
2007-08-13 13:22                   ` Avi Kivity
2007-08-13 14:15           ` Christian Borntraeger
     [not found]             ` <200708131615.42643.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-08-13 14:19               ` Avi Kivity
     [not found]                 ` <46C06885.3020908-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-13 14:26                   ` Christian Borntraeger
     [not found]                     ` <200708131626.36275.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-08-13 14:37                       ` Avi Kivity
     [not found]                         ` <46C06CA2.8010303-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-13 20:40                           ` Heiko Carstens
     [not found]                             ` <20070813204023.GA10283-5VkHqLvV2o3MbYB6QlFGEg@public.gmane.org>
2007-08-19  9:32                               ` List stripping out cc's (was: Re: [PATCH 0/2][KVM] guest time accounting) Avi Kivity
     [not found]                                 ` <46C80E40.9-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-19 19:53                                   ` List stripping out cc's Jeff Garzik
     [not found]                                     ` <46C89FCA.3010802-o2qLIJkoznsdnm+yROfE0A@public.gmane.org>
2007-08-19 20:10                                       ` Avi Kivity
2007-08-13 14:05   ` [PATCH 0/2][KVM] guest time accounting Christian Borntraeger
     [not found]     ` <200708131605.40479.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-08-13 14:10       ` Avi Kivity
     [not found]         ` <46C06638.6010108-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-13 14:22           ` Christian Borntraeger
2007-08-13 14:22       ` Laurent Vivier [this message]
     [not found]         ` <46C0693A.1080900-6ktuUTfB/bM@public.gmane.org>
2007-08-13 14:30           ` Avi Kivity
     [not found]             ` <46C06AFE.2050702-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
2007-08-13 14:41               ` Laurent Vivier
     [not found]                 ` <46C06D99.2030106-6ktuUTfB/bM@public.gmane.org>
2007-08-13 15:22                   ` Christian Borntraeger
     [not found]                     ` <200708131722.43936.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-08-13 15:36                       ` Laurent Vivier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=46C0693A.1080900@bull.net \
    --to=laurent.vivier-6ktuutfb/bm@public.gmane.org \
    --cc=borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org \
    --cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
    --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox