From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Vivier Subject: Re: [PATCH 0/2][KVM] guest time accounting Date: Mon, 13 Aug 2007 16:22:50 +0200 Message-ID: <46C0693A.1080900@bull.net> References: <46BC8B39.6050202@bull.net> <200708131605.40479.borntraeger@de.ibm.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1347312227==" Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, linux-kernel To: Christian Borntraeger Return-path: In-Reply-To: <200708131605.40479.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============1347312227== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig17F904F63489DD33255C7245" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig17F904F63489DD33255C7245 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Christian Borntraeger wrote: > Am Freitag, 10. August 2007 schrieb Laurent Vivier: >> The aim of these two patches is to measure the CPU time used by a virt= ual >> machine. All comments are welcome... I'm not sure it's the good way to= do=20 > that. >=20 > I did something similar for or s390guest prototype, that Carsten posted= in=20 > May. I decided to account guest time to the user process instead of ad= ding a=20 > new field to avoid hazzle with old top. As you can read in the patch co= mment,=20 > I personally prefer a new field if we can get one. >=20 > My implementation uses a similar mechanism like hard and softirq. So I = have an=20 > sie_enter an sie_exit and a task_is_in_sie function - like irq_enter an= d=20 > irq_exit. The main difference is based on the fact, that s390 has preci= se=20 > accouting for irq, steal, user and system time, and therefore my patch = is=20 > based on architecture specifc code using CONFIG_VIRT_CPU_ACCOUNT.=20 >=20 > In general my patch has the same idea as your patch, so I am going to r= eview=20 > your patch and see if it would fit for s390. >=20 > For reference this is the (never posted) old patch for our virtualisati= on=20 > prototype. It wont work with kvm but it gives you the idea what we had = in=20 > mind on s390. >=20 thank you for your comment. As virtualization becomes very popular, perhaps we should implement somet= hing which could be used by all linux supported architectures ? (yes, I know it's non-sense for archs like m68k...) But my [PATCH 1/2] can be a good start (adding "guest" in cpustat) As guest accounting is hw dependent, I think we should add a hook in the accounting functions. Laurent --=20 ------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org -------------- "Software is hard" - Donald Knuth --------------enig17F904F63489DD33255C7245 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.7 (GNU/Linux) iD8DBQFGwGk+9Kffa9pFVzwRAjcQAJ9KWtGGM50u/4sypi4myGY7IJyA6wCgoBNC +GNRE5w60CEhMhMt6gXHn5Y= =bPBU -----END PGP SIGNATURE----- --------------enig17F904F63489DD33255C7245-- --===============1347312227== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ --===============1347312227== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --===============1347312227==--