Re: [PATCH 0/2][KVM] guest time accounting

Avi Kivity
2007-08-13T14:10:00Z

Christian Borntraeger wrote:
> Am Freitag, 10. August 2007 schrieb Laurent Vivier:
>
>> The aim of these two patches is to measure the CPU time used by a virtual
>> machine. All comments are welcome... I'm not sure it's the good way to do
>>
> that.
>
> I did something similar for or s390guest prototype, that Carsten posted in
> May. I decided to account guest time to the user process instead of adding a
> new field to avoid hazzle with old top. As you can read in the patch comment,
> I personally prefer a new field if we can get one.
>

Laurent's patch gives the best of both worlds: on old 'top', you get
guest time accounted as user time, while on new 'top' it is accounted
separately. This is done by reporting user time as the sum of the real
user time and guest time. A newer 'top' can subtract guest time from
user time to get the correct statistic.

> My implementation uses a similar mechanism like hard and softirq. So I have an
> sie_enter an sie_exit and a task_is_in_sie function - like irq_enter and
> irq_exit. The main difference is based on the fact, that s390 has precise
> accouting for irq, steal, user and system time, and therefore my patch is
> based on architecture specifc code using CONFIG_VIRT_CPU_ACCOUNT.
>

Okay, so the code should be under that config option, and kvm should
select it.

--
error compiling committee.c: too many arguments to function