lapic3 branch rebased

lapic3 branch rebased

[Avi Kivity]

lapic3 has been rebased, compile tested, and pushed.  note that this 
does not include the patch-folding work I'd like to do before merging 
into master.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: lapic3 branch rebased

[Dong, Eddie]

Avi Kivity wrote:
> lapic3 has been rebased, compile tested, and pushed.  note that this
> does not include the patch-folding work I'd like to do before merging
> into master. 
> 
Thanks and verified it is fine for RHEL5U, XPSP2, FC5, Win2003. So feel
free to 
fold the patches and wanna to see merging soon :-)
thx,eddie

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: lapic3 branch rebased

[Avi Kivity]

Dong, Eddie wrote:
> Avi Kivity wrote:
>   
>> lapic3 has been rebased, compile tested, and pushed.  note that this
>> does not include the patch-folding work I'd like to do before merging
>> into master. 
>>
>>     
> Thanks and verified it is fine for RHEL5U, XPSP2, FC5, Win2003. So feel
> free to 
> fold the patches and wanna to see merging soon :-)
>   

FC6 SMP boots with one cpu only.  With -no-kvm-irqchip it boots fine.

Are you using the bios provided by kvm or the hacked one?  That may be 
the problem.

(I'm proceeding with the folding anyway)


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: lapic3 branch rebased

[Avi Kivity]

Dong, Eddie wrote:
> Avi Kivity wrote:
>   
>> lapic3 has been rebased, compile tested, and pushed.  note that this
>> does not include the patch-folding work I'd like to do before merging
>> into master. 
>>
>>     
> Thanks and verified it is fine for RHEL5U, XPSP2, FC5, Win2003. So feel
> free to 
> fold the patches and wanna to see merging soon :-)
> thx,eddie
>   

Some progress -- I rebased lapic3 and folded some patches; new branch 
called lapic4, 100% equivalent to lapic3 in final result.

Patches folded:

 KVM: cleanups on user/kernel irqchip checking
 KVM: Fix state save bug
 KVM: remove status in kvm_lapic structure
 KVM: Restore apic_base to struct kvm_vcpu
 KVM: Fix crash due to apic being accessed beore initialization
 KVM: Add missing #include
 KVM: IOAPIC: Temporarily avoid reissuing irq on EOI
 KVM: IOAPIC: Avoid delivering apic messages to non-existent vcpus
 KVM: Rename KVM_CAP_PIC to KVM_CAP_IRQCHIP
 KVM: Fix minor warnings in lapic patch
 KVM: Fix oops destroying VM with virtual PIC

Patches kept:

 KVM: pending irq save/restore
 KVM: in-kernel LAPIC save and restore support
 KVM: in-kernel IOAPIC save and restore support
 KVM: Bypass irq_pending get/set when using in kernel irqchip
 KVM: Add get/set irqchip ioctls for in-kernel PIC live migration support
 KVM: Protect in-kernel pio using kvm->lock
 KVM: Emulate hlt in the kernel
 KVM: In-kernel I/O APIC model
 KVM: Emulate local APIC in kernel
 KVM: Define and use cr8 access functions
 KVM: Add support for in-kernel PIC emulation

I plan to do some minor renaming and code movement (to remove artifacts 
like a line being moved by a patch for no reason).  Will be in a new 
branch lapic5.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: lapic3 branch rebased

[Avi Kivity]

Avi Kivity wrote:
> Dong, Eddie wrote:
>> Avi Kivity wrote:
>>  
>>> lapic3 has been rebased, compile tested, and pushed.  note that this
>>> does not include the patch-folding work I'd like to do before merging
>>> into master.
>>>     
>> Thanks and verified it is fine for RHEL5U, XPSP2, FC5, Win2003. So feel
>> free to fold the patches and wanna to see merging soon :-)
>> thx,eddie
>>   
>
> Some progress -- I rebased lapic3 and folded some patches; new branch 
> called lapic4, 100% equivalent to lapic3 in final result.
>
> Patches folded:
>
> KVM: cleanups on user/kernel irqchip checking
> KVM: Fix state save bug
> KVM: remove status in kvm_lapic structure
> KVM: Restore apic_base to struct kvm_vcpu
> KVM: Fix crash due to apic being accessed beore initialization
> KVM: Add missing #include
> KVM: IOAPIC: Temporarily avoid reissuing irq on EOI
> KVM: IOAPIC: Avoid delivering apic messages to non-existent vcpus
> KVM: Rename KVM_CAP_PIC to KVM_CAP_IRQCHIP
> KVM: Fix minor warnings in lapic patch
> KVM: Fix oops destroying VM with virtual PIC
>
> Patches kept:
>
> KVM: pending irq save/restore
> KVM: in-kernel LAPIC save and restore support
> KVM: in-kernel IOAPIC save and restore support
> KVM: Bypass irq_pending get/set when using in kernel irqchip
> KVM: Add get/set irqchip ioctls for in-kernel PIC live migration support
> KVM: Protect in-kernel pio using kvm->lock
> KVM: Emulate hlt in the kernel
> KVM: In-kernel I/O APIC model
> KVM: Emulate local APIC in kernel
> KVM: Define and use cr8 access functions
> KVM: Add support for in-kernel PIC emulation
>
> I plan to do some minor renaming and code movement (to remove 
> artifacts like a line being moved by a patch for no reason).  Will be 
> in a new branch lapic5.
>

This is now done, containing the following changes:

- rename 'struct kvm_ioctl_pic' to 'struct kvm_pic_state'
- rename 'struct kvm_ioctl_ioapic' to 'struct kvm_ioapic_state'
- rearranged struct kvm_vcpu to reduce changes relative ro master

However, neither lapic4 nor lapic5 will boot Windows XP SP2 (ACPI HAL).  
I'll debug the Linux problem first.



-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: lapic3 branch rebased

[Zhao, Yunfeng]

Hi, Avi
In my testing for lapic5, I can boot Windows guest with UP ACPI HAL. 
And I cannot boot Windows Guest with SMP ACPI HAL even with enabling
smp=1

Thanks
Yunfeng
>This is now done, containing the following changes:
>
>- rename 'struct kvm_ioctl_pic' to 'struct kvm_pic_state'
>- rename 'struct kvm_ioctl_ioapic' to 'struct kvm_ioapic_state'
>- rearranged struct kvm_vcpu to reduce changes relative ro master
>
>However, neither lapic4 nor lapic5 will boot Windows XP SP2 (ACPI HAL).
>I'll debug the Linux problem first.
>
>
>
>--
>error compiling committee.c: too many arguments to function
>
>
>-----------------------------------------------------------------------
--
>This SF.net email is sponsored by: Splunk Inc.
>Still grepping through log files to find problems?  Stop.
>Now Search log events and configuration files using AJAX and a browser.
>Download your FREE copy of Splunk now >>  http://get.splunk.com/
>_______________________________________________
>kvm-devel mailing list
>kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>https://lists.sourceforge.net/lists/listinfo/kvm-devel

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: lapic3 branch rebased

[Zhao, Yunfeng]

[-- Attachment #1: Type: text/plain, Size: 3408 bytes --]

Hi,Avi
Do you see any timer issue on Lapic5?
On lapic5 I found that linux guest has a big time lag while running kernel build.
With network time the time cost is about 450s, but guest timer reports 899s.

I didn't meet the issue on lapic3.

Thanks
Yunfeng
 
>-----Original Message-----
>From: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>[mailto:kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org] On Behalf Of Avi Kivity
>Sent: 2007年8月14日 20:09
>To: Dong, Eddie
>Cc: kvm-devel; He, Qing
>Subject: Re: [kvm-devel] lapic3 branch rebased
>
>Avi Kivity wrote:
>> Dong, Eddie wrote:
>>> Avi Kivity wrote:
>>>
>>>> lapic3 has been rebased, compile tested, and pushed.  note that this
>>>> does not include the patch-folding work I'd like to do before merging
>>>> into master.
>>>>
>>> Thanks and verified it is fine for RHEL5U, XPSP2, FC5, Win2003. So feel
>>> free to fold the patches and wanna to see merging soon :-)
>>> thx,eddie
>>>
>>
>> Some progress -- I rebased lapic3 and folded some patches; new branch
>> called lapic4, 100% equivalent to lapic3 in final result.
>>
>> Patches folded:
>>
>> KVM: cleanups on user/kernel irqchip checking
>> KVM: Fix state save bug
>> KVM: remove status in kvm_lapic structure
>> KVM: Restore apic_base to struct kvm_vcpu
>> KVM: Fix crash due to apic being accessed beore initialization
>> KVM: Add missing #include
>> KVM: IOAPIC: Temporarily avoid reissuing irq on EOI
>> KVM: IOAPIC: Avoid delivering apic messages to non-existent vcpus
>> KVM: Rename KVM_CAP_PIC to KVM_CAP_IRQCHIP
>> KVM: Fix minor warnings in lapic patch
>> KVM: Fix oops destroying VM with virtual PIC
>>
>> Patches kept:
>>
>> KVM: pending irq save/restore
>> KVM: in-kernel LAPIC save and restore support
>> KVM: in-kernel IOAPIC save and restore support
>> KVM: Bypass irq_pending get/set when using in kernel irqchip
>> KVM: Add get/set irqchip ioctls for in-kernel PIC live migration support
>> KVM: Protect in-kernel pio using kvm->lock
>> KVM: Emulate hlt in the kernel
>> KVM: In-kernel I/O APIC model
>> KVM: Emulate local APIC in kernel
>> KVM: Define and use cr8 access functions
>> KVM: Add support for in-kernel PIC emulation
>>
>> I plan to do some minor renaming and code movement (to remove
>> artifacts like a line being moved by a patch for no reason).  Will be
>> in a new branch lapic5.
>>
>
>This is now done, containing the following changes:
>
>- rename 'struct kvm_ioctl_pic' to 'struct kvm_pic_state'
>- rename 'struct kvm_ioctl_ioapic' to 'struct kvm_ioapic_state'
>- rearranged struct kvm_vcpu to reduce changes relative ro master
>
>However, neither lapic4 nor lapic5 will boot Windows XP SP2 (ACPI HAL).
>I'll debug the Linux problem first.
>
>
>
>--
>error compiling committee.c: too many arguments to function
>
>
>-------------------------------------------------------------------------
>This SF.net email is sponsored by: Splunk Inc.
>Still grepping through log files to find problems?  Stop.
>Now Search log events and configuration files using AJAX and a browser.
>Download your FREE copy of Splunk now >>  http://get.splunk.com/
>_______________________________________________
>kvm-devel mailing list
>kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
>https://lists.sourceforge.net/lists/listinfo/kvm-devel


[-- Attachment #2: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: lapic3 branch rebased

[Avi Kivity]

[-- Attachment #1: Type: text/plain, Size: 411 bytes --]

Zhao, Yunfeng wrote:
> Hi,Avi
> Do you see any timer issue on Lapic5?
> On lapic5 I found that linux guest has a big time lag while running kernel build.
> With network time the time cost is about 450s, but guest timer reports 899s.
>
> I didn't meet the issue on lapic3.
>
>   

No, I didn't. lapic3 and lapic5 shouldn't be that different...


-- 
error compiling committee.c: too many arguments to function



[-- Attachment #2: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: lapic3 branch rebased

[Dong, Eddie]

>- rename 'struct kvm_ioctl_pic' to 'struct kvm_pic_state'
>- rename 'struct kvm_ioctl_ioapic' to 'struct kvm_ioapic_state'
>- rearranged struct kvm_vcpu to reduce changes relative ro master
>
>However, neither lapic4 nor lapic5 will boot Windows XP SP2 
>(ACPI HAL).  
>I'll debug the Linux problem first.
>
>
Avi:
	I am just back from a travel and want to know what is next in
your plan.
	From the mailing list the XP ACPI HAL issue is fixed by Qing,
isn't it?
thx,eddie

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: lapic3 branch rebased

[Avi Kivity]

Dong, Eddie wrote:
>   
>> - rename 'struct kvm_ioctl_pic' to 'struct kvm_pic_state'
>> - rename 'struct kvm_ioctl_ioapic' to 'struct kvm_ioapic_state'
>> - rearranged struct kvm_vcpu to reduce changes relative ro master
>>
>> However, neither lapic4 nor lapic5 will boot Windows XP SP2 
>> (ACPI HAL).  
>> I'll debug the Linux problem first.
>>
>>
>>     
> Avi:
> 	I am just back from a travel and want to know what is next in
> your plan.
> 	From the mailing list the XP ACPI HAL issue is fixed by Qing,
> isn't it?
>   

I assume it is (haven't checked myself).  But of course we need to get 
guest smp working.

I made some progress but it isn't working yet.  If you have something, 
please post it.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/