From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: lapic3 branch rebased Date: Tue, 14 Aug 2007 15:08:49 +0300 Message-ID: <46C19B51.9010502@qumranet.com> References: <46C07949.6090001@qumranet.com> <10EA09EFD8728347A513008B6B0DA77A01E8E414@pdsmsx411.ccr.corp.intel.com> <46C17D21.607@qumranet.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , "He, Qing" To: "Dong, Eddie" Return-path: In-Reply-To: <46C17D21.607-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Avi Kivity wrote: > Dong, Eddie wrote: >> Avi Kivity wrote: >> >>> lapic3 has been rebased, compile tested, and pushed. note that this >>> does not include the patch-folding work I'd like to do before merging >>> into master. >>> >> Thanks and verified it is fine for RHEL5U, XPSP2, FC5, Win2003. So feel >> free to fold the patches and wanna to see merging soon :-) >> thx,eddie >> > > Some progress -- I rebased lapic3 and folded some patches; new branch > called lapic4, 100% equivalent to lapic3 in final result. > > Patches folded: > > KVM: cleanups on user/kernel irqchip checking > KVM: Fix state save bug > KVM: remove status in kvm_lapic structure > KVM: Restore apic_base to struct kvm_vcpu > KVM: Fix crash due to apic being accessed beore initialization > KVM: Add missing #include > KVM: IOAPIC: Temporarily avoid reissuing irq on EOI > KVM: IOAPIC: Avoid delivering apic messages to non-existent vcpus > KVM: Rename KVM_CAP_PIC to KVM_CAP_IRQCHIP > KVM: Fix minor warnings in lapic patch > KVM: Fix oops destroying VM with virtual PIC > > Patches kept: > > KVM: pending irq save/restore > KVM: in-kernel LAPIC save and restore support > KVM: in-kernel IOAPIC save and restore support > KVM: Bypass irq_pending get/set when using in kernel irqchip > KVM: Add get/set irqchip ioctls for in-kernel PIC live migration support > KVM: Protect in-kernel pio using kvm->lock > KVM: Emulate hlt in the kernel > KVM: In-kernel I/O APIC model > KVM: Emulate local APIC in kernel > KVM: Define and use cr8 access functions > KVM: Add support for in-kernel PIC emulation > > I plan to do some minor renaming and code movement (to remove > artifacts like a line being moved by a patch for no reason). Will be > in a new branch lapic5. > This is now done, containing the following changes: - rename 'struct kvm_ioctl_pic' to 'struct kvm_pic_state' - rename 'struct kvm_ioctl_ioapic' to 'struct kvm_ioapic_state' - rearranged struct kvm_vcpu to reduce changes relative ro master However, neither lapic4 nor lapic5 will boot Windows XP SP2 (ACPI HAL). I'll debug the Linux problem first. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/