Re: Error while inserting kvm-intel.ko from kvm-34

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Glauber de Oliveira Costa wrote:
>>  I got the same behaviour here, and it seems that the reason is 32-bit
>> machines does not use the CR8 register. But the code in vmx.c makes it
>> a minimum requirement as in:
>>
>>         min = CPU_BASED_HLT_EXITING |
>>               CPU_BASED_CR8_LOAD_EXITING |
>>               CPU_BASED_CR8_STORE_EXITING |
>>               CPU_BASED_USE_IO_BITMAPS |
>>               CPU_BASED_MOV_DR_EXITING |
>>               CPU_BASED_USE_TSC_OFFSETING;
>>
>> I think the solution is to enclose the CR8 constants in a ifdef
>> CONFIG_X86_64, since putting them as optional won't do the right thing
>> in 64-bit (and thus, core duo), machines.
>>
>> I was about to post a patch for it now.
>>
>> Avi, if you agree with the fix, I can do it right now.
>>
>>     
>
> BTW, in case you agree, here is the patch
>
>   

Applied, thanks.  Good catch.

> commit 2863174b39dd8768cd7922832e45ea00d5c6442c
> Author: Glauber de Oliveira Costa <glauber-aMxvdZfKFXomYvmMESoHnA@public.gmane.org>
> Date:   Tue Aug 14 15:51:22 2007 -0300

Author email is misconfigured...


-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/