From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: Error while inserting kvm-intel.ko from kvm-34 Date: Wed, 15 Aug 2007 05:38:05 +0300 Message-ID: <46C2670D.2090707@qumranet.com> References: <269694c00708130859n6a375022r1e84c7609565147b@mail.gmail.com> <46C0807D.3060303@qumranet.com> <269694c00708130903l100827d4h10d903b2efcf1fbf@mail.gmail.com> <46C081DF.4020502@qumranet.com> <269694c00708130944y24fcd60dv6cfad494927937ab@mail.gmail.com> <46C1D401.8030303@qumranet.com> <5d6222a80708141114p244901d4sa7ddda7abeb7ef27@mail.gmail.com> <5d6222a80708141155y192c3db4ha01d537a475c6c6b@mail.gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org, =?UTF-8?B?IijgpIXgpK7gpYfgpK8pIEFtZXlhICjgpKrgpL7gpLPgpILgpKbgpYcpIFBh?=@sc8-sf-spam2.sourceforge.net, =?UTF-8?B?bGFuZGUi?= <2ameya-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> To: Glauber de Oliveira Costa Return-path: In-Reply-To: <5d6222a80708141155y192c3db4ha01d537a475c6c6b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Glauber de Oliveira Costa wrote: >> I got the same behaviour here, and it seems that the reason is 32-bit >> machines does not use the CR8 register. But the code in vmx.c makes it >> a minimum requirement as in: >> >> min = CPU_BASED_HLT_EXITING | >> CPU_BASED_CR8_LOAD_EXITING | >> CPU_BASED_CR8_STORE_EXITING | >> CPU_BASED_USE_IO_BITMAPS | >> CPU_BASED_MOV_DR_EXITING | >> CPU_BASED_USE_TSC_OFFSETING; >> >> I think the solution is to enclose the CR8 constants in a ifdef >> CONFIG_X86_64, since putting them as optional won't do the right thing >> in 64-bit (and thus, core duo), machines. >> >> I was about to post a patch for it now. >> >> Avi, if you agree with the fix, I can do it right now. >> >> > > BTW, in case you agree, here is the patch > > Applied, thanks. Good catch. > commit 2863174b39dd8768cd7922832e45ea00d5c6442c > Author: Glauber de Oliveira Costa > Date: Tue Aug 14 15:51:22 2007 -0300 Author email is misconfigured... -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/