From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Patch] (big) real mode emulation - jmp rel Date: Fri, 17 Aug 2007 15:24:37 +0300 Message-ID: <46C59385.6060108@qumranet.com> References: <1186785157.6097.19.camel@lnitindesktop.sc.intel.com> <46C01B0E.7080304@qumranet.com> <1187226935.24576.5.camel@lnitindesktop.sc.intel.com> <46C42610.8020707@qumranet.com> <1187296469.5500.7.camel@lnitindesktop.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel , "Yu, Wilfred" To: nitin.a.kamble-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <1187296469.5500.7.camel-mpPvwfgnXtFHIUuj5cj4Omt3HXsI98Cx0E9HWUfgJXw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Nitin A Kamble wrote: > Avi, > In my opinion converting this small function to file-scope function, > would make code look ugly. I think the earlier Macro definition was > better. > > A file scope function would indeed be uglier. But the macro has more serious problems; it's impossible to understand how variables are affected since nobody expects function local variables whose address is not taken to change after something that looks like a macro is called. At the very least, it needs to be in uppercase so that people know something funny is going on. But it's really better as a function. (and yes, the rest of the file uses macros. and yes, the rest of the file is an unmaintainable mess) > On Thu, 2007-08-16 at 03:25 -0700, Avi Kivity wrote: > >>> + inline void jmp_rel(int rel) >>> + { >>> + _eip += (int)(rel); >>> + _eip = ((op_bytes == 2) ? (uint16_t)_eip : >>> >> (uint32_t)_eip); >> >>> + }; >>> + >>> >> This is a nested function which we don't use (in the kernel or >> userspace). >> >> It needs to be a file-scope function (static, too). >> > > -- Do not meddle in the internals of kernels, for they are subtle and quick to panic. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/