Re: [PATCH/RFC 3/4]Introduce "account modifiers" mechanism

Rusty Russell
2007-08-16T22:39:15Z

On Thu, 2007-08-16 at 17:58 +0200, Laurent Vivier wrote:
> [PATCH 3/3] introduce "account modifiers" mechanism in the kernel allowing a
> module to modify the collected accounting for a given task. This implementation
> is based on the "preempt_notifier". "account_system_time()" and
> "account_user_time()" can call functions registered by a module to modify the
> cputime value.
>
> Signed-off-by: Laurent Vivier <Laurent.Vivier@bull.net>

Hi Laurent,

This seems a little like overkill. Why not just add an
"account_guest_time" which subtracts the given amount of time from
system time (if available) and adds it to guest time? Then kvm (and
lguest) should just need to call this at the right times.

Am I missing something?
Rusty.