Re: [Patch] (big) real mode emulation - sorted opcodes

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Nitin A Kamble wrote:
> On Fri, 2007-08-17 at 05:18 -0700, Avi Kivity wrote:
>   
>> Applied, thanks.
>>
>> Please keep opcodes in sorted order, and don't post patches in dos
>> format.
>>
>>
>>     
> Hi Avi,
>   Attached is the patch, doing code cleanup. It keeps the emulation of
> op-codes in sorted order. Also removes the white-space before labels.
>
>   I don't see any reason for it to reach you in the dos format. I use
> evolution to send email, and I am sending it from my Linux desktop. Only
> thing is I have to go through the Exchange server to send email. Can you
> send back one of my patch? I will check what is happening.
>
>   

Actually it unindents the labels too much... the convention is to 
unindent labels just one level.  Not that it is imporant.

Anyway, this patch got translated into DOS format as well:

[avi@cleopatra linux-2.6 (master)]$ od -t x1  ~/opcodes_sorted.patch  | head
0000000 63 6f 6d 6d 69 74 20 63 36 30 39 32 36 39 65 62
0000020 63 34 30 65 33 38 35 65 63 35 61 38 32 33 36 33
0000040 64 35 65 65 34 61 34 39 33 38 38 37 37 36 63 0d
0000060 0a 41 75 74 68 6f 72 3a 20 4e 69 74 69 6e 20 41
0000100 20 4b 61 6d 62 6c 65 20 3c 6e 69 74 69 6e 2e 61
0000120 2e 6b 61 6d 62 6c 65 40 69 6e 74 65 6c 2e 63 6f
0000140 6d 3e 0d 0a 44 61 74 65 3a 20 20 20 46 72 69 20
0000160 41 75 67 20 31 37 20 31 38 3a 32 31 3a 30 38 20
0000200 32 30 30 37 20 2d 30 37 30 30 0d 0a 0d 0a 20 20
0000220 20 20 52 65 61 72 72 61 6e 67 65 20 74 68 65 20


Note the sequences of '0d 0a'.

-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/