Re: [Patch] (big) real mode emulation - jmp rel

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Nitin A Kamble wrote:
> On Fri, 2007-08-17 at 05:24 -0700, Avi Kivity wrote:
>   
>> A file scope function would indeed be uglier.  But the macro has more
>> serious problems; it's impossible to understand how variables are
>> affected since nobody expects function local variables whose address
>> is
>> not taken to change after something that looks like a macro is called.
>>
>> At the very least, it needs to be in uppercase so that people know
>> something funny is going on.  But it's really better as a function.
>>
>> (and yes, the rest of the file uses macros.  and yes, the rest of the
>> file is an unmaintainable mess)
>>     
>
> Hi Avi,
>   I tried either ways, and to me the macro looks cleaner. Now I have
> upper-cased it for your satisfaction. :)
>   Also attached the "jmp rel short" emulation patch.
>
>   

Okay, applied both -- thanks.


-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/