From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [Patch] (big) real mode emulation - jmp rel Date: Sun, 19 Aug 2007 11:03:38 +0300 Message-ID: <46C7F95A.9090504@qumranet.com> References: <1186785157.6097.19.camel@lnitindesktop.sc.intel.com> <46C01B0E.7080304@qumranet.com> <1187226935.24576.5.camel@lnitindesktop.sc.intel.com> <46C42610.8020707@qumranet.com> <1187296469.5500.7.camel@lnitindesktop.sc.intel.com> <46C59385.6060108@qumranet.com> <1187389499.9011.14.camel@lnitindesktop.sc.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: nitin.a.kamble-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org Return-path: In-Reply-To: <1187389499.9011.14.camel-mpPvwfgnXtFHIUuj5cj4Omt3HXsI98Cx0E9HWUfgJXw@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Nitin A Kamble wrote: > On Fri, 2007-08-17 at 05:24 -0700, Avi Kivity wrote: > >> A file scope function would indeed be uglier. But the macro has more >> serious problems; it's impossible to understand how variables are >> affected since nobody expects function local variables whose address >> is >> not taken to change after something that looks like a macro is called. >> >> At the very least, it needs to be in uppercase so that people know >> something funny is going on. But it's really better as a function. >> >> (and yes, the rest of the file uses macros. and yes, the rest of the >> file is an unmaintainable mess) >> > > Hi Avi, > I tried either ways, and to me the macro looks cleaner. Now I have > upper-cased it for your satisfaction. :) > Also attached the "jmp rel short" emulation patch. > > Okay, applied both -- thanks. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/