Re: [Qemu-devel] [PATCH 0/4] Rework alarm timer infrastrucure - take 2

Christian MICHON
2007-08-17T23:48:01Z

On 8/18/07, Luca Tettamanti <kronos.it-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> Hello,
> in reply to this mail I will send a serie of 4 patches that cleans up and
> expands the alarm timer handling in QEMU. Patches have been rebased on QEMU
> CVS.
>
> Patch 1 is mostly a cleanup of the existing code; instead of having multiple
> #ifdefs to handle different timers scattered all over the code I've created a
> modular infrastructure where each timer type is self-contained and generic code
> is more readable. The resulting code is functionally equivalent to the old one.
>
> Patch 2 implements the "-clock" command line option proposed by Daniel Berrange
> and Avi Kivity. By default QEMU tries RTC and then falls back to unix timer;
> user can override the order of the timer through this options. Syntax is pretty
> simple: -clock timer1,timer2,etc. (QEMU will pick the first one that works).
>
> Patch 3 adds support for HPET under Linux (which is basically my old patch). As
> suggested HPET takes precedence over other timers, but of course this can be
> overridden.
>
> Patch 4 introduces "dynticks" timer source; patch is mostly based on the work
> Dan Kenigsberg. dynticks is now the default alarm timer.
>
> Luca
> --
>
>
>

there's a typo line 1432 on vl.c after applying all 4 patches
(missing ';')

C:/msys/1.0/home/Xian/qemu/vl.c: In function `win32_start_timer':
C:/msys/1.0/home/Xian/qemu/vl.c:1432: error: syntax error before '}' token
make[1]: *** [vl.o] Error 1

beyond this small typo, I managed to include this in a win32 qemu build.
is there a specific practical test to see the improvement in a linux guest
when running on a windows host ?

--
Christian
--
http://detaolb.sourceforge.net/, a linux distribution for Qemu