From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Vivier Subject: Re: [PATCH/RFC 3/4]Introduce "account modifiers" mechanism Date: Mon, 20 Aug 2007 09:30:14 +0200 Message-ID: <46C94306.8080300@bull.net> References: <46C4719A.2060308@bull.net> <46C4720F.7030304@bull.net> <46C4725A.4070607@bull.net> <46C4740F.2050701@bull.net> <1187303955.6449.7.camel@localhost.localdomain> <46C54FB8.7050504@bull.net> <1187339450.6449.115.camel@localhost.localdomain> <46C56774.2030009@bull.net> <46C59AB1.6070505@qumranet.com> <46C5ACE8.2050004@bull.net> <46C7F362.80106@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1520528053==" Cc: kvm-devel , linux-kernel , virtualization To: Avi Kivity Return-path: In-Reply-To: <46C7F362.80106-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============1520528053== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enig7C737AE7EF4E858B3CFE62D6" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enig7C737AE7EF4E858B3CFE62D6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > Laurent Vivier wrote: >> Avi Kivity wrote: >> [...] >> =20 >>> The normal user/system accounting has the same issue, no? Whereever = we >>> happen to land (kernel or user) gets the whole tick. >>> >>> So I think it is okay to have the same limitation for guest time. >>> >>> =20 >> >> So this is how it looks like. >> PATCH 1 and 2 are always a prerequisite. >> >> =20 >=20 >> + tmp =3D cputime_to_cputime64(cputime); >> + if (p->flags & PF_VCPU) { >> + p->utime =3D cputime_add(p->utime, cputime); >> + p->gtime =3D cputime_add(p->gtime, cputime); >> + >> + cpustat->guest =3D cputime64_add(cpustat->guest, tmp); >> + cpustat->user =3D cputime64_add(cpustat->user, tmp); >> + >> + p->flags &=3D ~PF_VCPU; >> + >> + return; >> + } >> + >=20 > Where did CONFIG_GUEST_ACCOUNTING go? >=20 Lost in the sea ... Actually, I thought this modification is not enough expensive (in time an= d space) to justify a CONFIG_*. But if you think so I can add this in init/= Kconfig. Laurent --=20 ------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org -------------- "Software is hard" - Donald Knuth --------------enig7C737AE7EF4E858B3CFE62D6 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.7 (GNU/Linux) iD8DBQFGyUMJ9Kffa9pFVzwRAkNfAJ9N5NHDYRg6q0uL28SuPT9ifCq8GQCfZOAM QuslB/f41g7GPG+L1cPgSqQ= =sAZD -----END PGP SIGNATURE----- --------------enig7C737AE7EF4E858B3CFE62D6-- --===============1520528053== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ --===============1520528053== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --===============1520528053==--