From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][Rebased LAPIC5] Enable TPR shadow on CR8 access Date: Tue, 21 Aug 2007 15:34:47 +0300 Message-ID: <46CADBE7.4080400@qumranet.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Yang, Sheng" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Yang, Sheng wrote: > This patch enabled TPR shadow of VMX on CR8 access. 64bit Windows using > CR8 > access TPR frequently. The TPR shadow can improve the performance of > access > TPR by not causing vmexit. > > Signed-off-by: Sheng Yang > > Notice: This patch based on the rebased lapic5, for the current lapic5 > is broken... > Wait, which lapic5 is broken and which is okay?! Can you explain? maybe post sha1 hashes? > +#define cpu_has_vmx_tpr_shadow \ > + (vmcs_config.cpu_based_exec_ctrl & CPU_BASED_TPR_SHADOW) > + > Inline function please. Why hide code in something that looks like a variable? > @@ -2128,6 +2165,7 @@ static void vmx_intr_assist(struct kvm_vcpu *vcpu) > vmx_inject_irq(vcpu, kvm_cpu_get_interrupt(vcpu)); > else > enable_irq_window(vcpu); > + > } > Superfluous empty line, please remove. Apart from this, code looks fine. But please explain what happened to the lapic5 branch? -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/