From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH][Rebased LAPIC5] Reading PPR directly from function rather than apic page Date: Tue, 21 Aug 2007 15:37:03 +0300 Message-ID: <46CADC6F.8060708@qumranet.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: "Yang, Sheng" Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Yang, Sheng wrote: > After introducing TPR shadow, many TPR change won't cause vmexit, so the > present method of updating PPR can't catch it. Though we can also update > PPR > everytime when we want to read PPR, it's somehow ugly. > > Because there are only two places need reading PPR, and PPR is > read-only, we > do it in more clear way. Now the apic_update_PPR() have been replaced by > apic_get_PPR() which returned current PPR, and we read the PPR directly > from > the function when we need it, rather than reading from apic page. > > Signed-off-by: Sheng Yang > > Notice: This patch based on the rebased lapic5, for the current lapic5 > is broken... > Patch is okay; pending only on the previous patch. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/