[PATCH] Add support for passing extra LDFLAGS to qemu's configure

[PATCH] Add support for passing extra LDFLAGS to qemu's configure

[Jeremy Katz]

[-- Attachment #1: Type: text/plain, Size: 380 bytes --]

There are cases[1] where you want to be able to pass more ldflags to
qemu's configure.  This lets you set LDFLAGS to accomplish that

Signed-off-by: Jeremy Katz <katzj-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>

Jeremy

[1] Such as with the new build-id support in binutils so that you can
pass --build-id to the linker while still building with the old compiler
as needed for qemu

[-- Attachment #2: kvm-35-ldflags.patch --]
[-- Type: text/x-patch, Size: 631 bytes --]

diff -up kvm-35/configure.ldflags kvm-35/configure
--- kvm-35/configure.ldflags	2007-08-20 17:40:39.000000000 -0400
+++ kvm-35/configure	2007-08-20 17:40:50.000000000 -0400
@@ -83,7 +83,7 @@ target_cpu() {
 (cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir")
 (cd qemu; ./configure --target-list=$(target_cpu)-softmmu --cc="$qemu_cc" \
     --disable-kqemu --extra-cflags="-I $PWD/../user" \
-    --extra-ldflags="-L $PWD/../user" \
+    --extra-ldflags="-L $PWD/../user $LDFLAGS" \
     --enable-kvm --kernel-path="$libkvm_kerneldir" \
     --enable-alsa \
     ${disable_gcc_check:+"--disable-gcc-check"} \

[-- Attachment #3: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

[-- Attachment #4: Type: text/plain, Size: 186 bytes --]

_______________________________________________
kvm-devel mailing list
kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
https://lists.sourceforge.net/lists/listinfo/kvm-devel

Re: [PATCH] Add support for passing extra LDFLAGS to qemu's configure

[Avi Kivity]

Jeremy Katz wrote:
> There are cases[1] where you want to be able to pass more ldflags to
> qemu's configure.  This lets you set LDFLAGS to accomplish that
>
> Signed-off-by: Jeremy Katz <katzj-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> Jeremy
>
> [1] Such as with the new build-id support in binutils so that you can
> pass --build-id to the linker while still building with the old compiler
> as needed for qemu
>   
> diff -up kvm-35/configure.ldflags kvm-35/configure
> --- kvm-35/configure.ldflags	2007-08-20 17:40:39.000000000 -0400
> +++ kvm-35/configure	2007-08-20 17:40:50.000000000 -0400
> @@ -83,7 +83,7 @@ target_cpu() {
>  (cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir")
>  (cd qemu; ./configure --target-list=$(target_cpu)-softmmu --cc="$qemu_cc" \
>      --disable-kqemu --extra-cflags="-I $PWD/../user" \
> -    --extra-ldflags="-L $PWD/../user" \
> +    --extra-ldflags="-L $PWD/../user $LDFLAGS" \
>      --enable-kvm --kernel-path="$libkvm_kerneldir" \
>      --enable-alsa \
>      ${disable_gcc_check:+"--disable-gcc-check"} \
>   

I utterly dislike slurping build options from the environment.  Please 
provide an explicit option.  Counterexamples in current code will not help.



-- 
error compiling committee.c: too many arguments to function


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/