From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH] Add support for passing extra LDFLAGS to qemu's configure Date: Tue, 21 Aug 2007 15:39:53 +0300 Message-ID: <46CADD19.8070501@qumranet.com> References: <1187646546.7085.153.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Jeremy Katz Return-path: In-Reply-To: <1187646546.7085.153.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Jeremy Katz wrote: > There are cases[1] where you want to be able to pass more ldflags to > qemu's configure. This lets you set LDFLAGS to accomplish that > > Signed-off-by: Jeremy Katz > > Jeremy > > [1] Such as with the new build-id support in binutils so that you can > pass --build-id to the linker while still building with the old compiler > as needed for qemu > > diff -up kvm-35/configure.ldflags kvm-35/configure > --- kvm-35/configure.ldflags 2007-08-20 17:40:39.000000000 -0400 > +++ kvm-35/configure 2007-08-20 17:40:50.000000000 -0400 > @@ -83,7 +83,7 @@ target_cpu() { > (cd user; ./configure --prefix="$prefix" --kerneldir="$libkvm_kerneldir") > (cd qemu; ./configure --target-list=$(target_cpu)-softmmu --cc="$qemu_cc" \ > --disable-kqemu --extra-cflags="-I $PWD/../user" \ > - --extra-ldflags="-L $PWD/../user" \ > + --extra-ldflags="-L $PWD/../user $LDFLAGS" \ > --enable-kvm --kernel-path="$libkvm_kerneldir" \ > --enable-alsa \ > ${disable_gcc_check:+"--disable-gcc-check"} \ > I utterly dislike slurping build options from the environment. Please provide an explicit option. Counterexamples in current code will not help. -- error compiling committee.c: too many arguments to function ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/