From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Vivier Subject: Re: [PATCH] Split segments reload in vmx_load_host_state() Date: Thu, 23 Aug 2007 15:02:26 +0200 Message-ID: <46CD8562.5000402@bull.net> References: <46CD81D5.90707@bull.net> <46CD8316.2040208@qumranet.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1568057386==" Cc: kvm-devel To: Avi Kivity Return-path: In-Reply-To: <46CD8316.2040208-atKUWr5tajBWk0Htik3J/w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --===============1568057386== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="------------enigF4D3FBFEB8490C43082D791D" This is an OpenPGP/MIME signed message (RFC 2440 and 3156) --------------enigF4D3FBFEB8490C43082D791D Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable Avi Kivity wrote: > Laurent Vivier wrote: >> It is from the TODO and I hope no one is already working on this. >> >> 'vmx_load_host_state() bundles fs, gs, ldt, and tss reloading into one= in the >> hope that it is infrequent. With smp guests, fs reloading is frequent = and the >> separate reloads should be unbundled.' >> >> =20 >=20 >> =20 >> }; >> @@ -353,20 +354,20 @@ static void vmx_save_host_state(struct v >> * allow segment selectors with cpl > 0 or ti =3D=3D 1. >> */ >> vmx->host_state.ldt_sel =3D read_ldt(); >> - vmx->host_state.fs_gs_ldt_reload_needed =3D vmx->host_state.ldt_sel;= >> + vmx->host_state.gs_ldt_reload_needed =3D vmx->host_state.ldt_sel; >> =20 >=20 > Missing initialization for fs_reload_needed here. >=20 It is initialized on fs_sel, should it be initialized on ldt_sel too ? Laurent --=20 ------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org -------------- "Software is hard" - Donald Knuth --------------enigF4D3FBFEB8490C43082D791D Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.2.7 (GNU/Linux) iD8DBQFGzYVm9Kffa9pFVzwRAqCWAJ4hSXdCAFSdHiJUNr3pujAQWsHvmgCfcqkh BuF5V5nUJti75cbzEnjzggM= =F0hQ -----END PGP SIGNATURE----- --------------enigF4D3FBFEB8490C43082D791D-- --===============1568057386== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ --===============1568057386== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --===============1568057386==--