Re: [PATCH] Split segments reload in vmx_load_host_state()

Laurent Vivier
2007-08-23T13:02:26Z

[-- Attachment #1.1: Type: text/plain, Size: 956 bytes --]

Avi Kivity wrote:
> Laurent Vivier wrote:
>> It is from the TODO and I hope no one is already working on this.
>>
>> 'vmx_load_host_state() bundles fs, gs, ldt, and tss reloading into one in the
>> hope that it is infrequent. With smp guests, fs reloading is frequent and the
>> separate reloads should be unbundled.'
>>
>>
>
>>
>> };
>> @@ -353,20 +354,20 @@ static void vmx_save_host_state(struct v
>> * allow segment selectors with cpl > 0 or ti == 1.
>> */
>> vmx->host_state.ldt_sel = read_ldt();
>> - vmx->host_state.fs_gs_ldt_reload_needed = vmx->host_state.ldt_sel;
>> + vmx->host_state.gs_ldt_reload_needed = vmx->host_state.ldt_sel;
>>
>
> Missing initialization for fs_reload_needed here.
>

It is initialized on fs_sel, should it be initialized on ldt_sel too ?

Laurent
--
------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org --------------
"Software is hard" - Donald Knuth

[-- Attachment #1.2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

[-- Attachment #2: Type: text/plain, Size: 315 bytes --]

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/

[-- Attachment #3: Type: text/plain, Size: 186 bytes --]