Re: [PATCH 2/4] [HYPERCALL] Enable userspace too include kvm_para.

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Dor Laor wrote:
> Since some hypercalls can be handled in userspace, it needs
> to include kvm_para too. Chande kernel types into user and
> add includes for them and for page_size.
> @@ -25,17 +28,17 @@ struct kvm_vcpu_para_state {
>  	 * is supposed to work - new host versions will support all old
>  	 * guest API versions.
>  	 */
> -	u32 guest_version;
> -	u32 host_version;
> -	u32 size;
> -	u32 ret;
> +	__u32 guest_version;
> +	__u32 host_version;
> +	__u32 size;
> +	__u32 ret;
>  
>  	/*
>  	 * The address of the vm exit instruction (VMCALL or VMMCALL),
>  	 * which the host will patch according to the CPU model the
>  	 * VM runs on:
>  	 */
> -	u64 hypercall_gpa;
> +	__u64 hypercall_gpa;
>  
>  } __attribute__ ((aligned(PAGE_SIZE)));
>
>
>   

But userspace isn't really interested in kvm_para_state, right?  You can
just wrap it in #ifdef __KERNEL__.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/