[PATCH 2/4] [HYPERCALL] Enable userspace too include kvm_para.

[PATCH 2/4] [HYPERCALL] Enable userspace too include kvm_para.

[Dor Laor]

Since some hypercalls can be handled in userspace, it needs
to include kvm_para too. Chande kernel types into user and
add includes for them and for page_size.

Signed-off-by: Dor Laor <dor.laor-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
---
 include/linux/kvm_para.h |   13 ++++++++-----
 1 files changed, 8 insertions(+), 5 deletions(-)

diff --git a/include/linux/kvm_para.h b/include/linux/kvm_para.h
index 3b29256..754e29d 100644
--- a/include/linux/kvm_para.h
+++ b/include/linux/kvm_para.h
@@ -8,6 +8,9 @@
  *       as we make progress.
  */
 
+#include <asm/types.h>
+#include <asm/page.h>
+
 /*
  * Per-VCPU descriptor area shared between guest and host. Writable to
  * both guest and host. Registered with the host by the guest when
@@ -25,17 +28,17 @@ struct kvm_vcpu_para_state {
 	 * is supposed to work - new host versions will support all old
 	 * guest API versions.
 	 */
-	u32 guest_version;
-	u32 host_version;
-	u32 size;
-	u32 ret;
+	__u32 guest_version;
+	__u32 host_version;
+	__u32 size;
+	__u32 ret;
 
 	/*
 	 * The address of the vm exit instruction (VMCALL or VMMCALL),
 	 * which the host will patch according to the CPU model the
 	 * VM runs on:
 	 */
-	u64 hypercall_gpa;
+	__u64 hypercall_gpa;
 
 } __attribute__ ((aligned(PAGE_SIZE)));


-----
In simplicity there is elegance.
Dor Laor ;)


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: [PATCH 2/4] [HYPERCALL] Enable userspace too include kvm_para.

[Avi Kivity]

Dor Laor wrote:
> Since some hypercalls can be handled in userspace, it needs
> to include kvm_para too. Chande kernel types into user and
> add includes for them and for page_size.
> @@ -25,17 +28,17 @@ struct kvm_vcpu_para_state {
>  	 * is supposed to work - new host versions will support all old
>  	 * guest API versions.
>  	 */
> -	u32 guest_version;
> -	u32 host_version;
> -	u32 size;
> -	u32 ret;
> +	__u32 guest_version;
> +	__u32 host_version;
> +	__u32 size;
> +	__u32 ret;
>  
>  	/*
>  	 * The address of the vm exit instruction (VMCALL or VMMCALL),
>  	 * which the host will patch according to the CPU model the
>  	 * VM runs on:
>  	 */
> -	u64 hypercall_gpa;
> +	__u64 hypercall_gpa;
>  
>  } __attribute__ ((aligned(PAGE_SIZE)));
>
>
>   

But userspace isn't really interested in kvm_para_state, right?  You can
just wrap it in #ifdef __KERNEL__.

-- 
Do not meddle in the internals of kernels, for they are subtle and quick to panic.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: [PATCH 2/4] [HYPERCALL] Enable userspace too include kvm_para.

[Dor Laor]

>> Since some hypercalls can be handled in userspace, it needs
>> to include kvm_para too. Chande kernel types into user and
>> add includes for them and for page_size.
>> @@ -25,17 +28,17 @@ struct kvm_vcpu_para_state {
>>  	 * is supposed to work - new host versions will support all old
>>  	 * guest API versions.
>>  	 */
>> -	u32 guest_version;
>> -	u32 host_version;
>> -	u32 size;
>> -	u32 ret;
>> +	__u32 guest_version;
>> +	__u32 host_version;
>> +	__u32 size;
>> +	__u32 ret;
>>
>>  	/*
>>  	 * The address of the vm exit instruction (VMCALL or VMMCALL),
>>  	 * which the host will patch according to the CPU model the
>>  	 * VM runs on:
>>  	 */
>> -	u64 hypercall_gpa;
>> +	__u64 hypercall_gpa;
>>
>>  } __attribute__ ((aligned(PAGE_SIZE)));
>>
>>
>>
>
>But userspace isn't really interested in kvm_para_state, right?  You
can
>just wrap it in #ifdef __KERNEL__.
>

Currently userspace is not interested by it might.
A nice thing would be to enable PV drivers with qemu only, so qemu will
catch the
wrmsr to the shared page.
Until then I'll add the __KERNEL__.
Thanks,
Dor.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/

Re: [PATCH 2/4] [HYPERCALL] Enable userspace too include kvm_para.

[Anthony Liguori]

Ignore my last email about this patch not existing :-)

Regards,

Anthony Liguori


On Fri, 2007-08-24 at 16:58 -0700, Dor Laor wrote:
> Since some hypercalls can be handled in userspace, it needs
> to include kvm_para too. Chande kernel types into user and
> add includes for them and for page_size.
> 
> Signed-off-by: Dor Laor <dor.laor-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
> ---
>  include/linux/kvm_para.h |   13 ++++++++-----
>  1 files changed, 8 insertions(+), 5 deletions(-)
> 
> diff --git a/include/linux/kvm_para.h b/include/linux/kvm_para.h
> index 3b29256..754e29d 100644
> --- a/include/linux/kvm_para.h
> +++ b/include/linux/kvm_para.h
> @@ -8,6 +8,9 @@
>   *       as we make progress.
>   */
>  
> +#include <asm/types.h>
> +#include <asm/page.h>
> +
>  /*
>   * Per-VCPU descriptor area shared between guest and host. Writable to
>   * both guest and host. Registered with the host by the guest when
> @@ -25,17 +28,17 @@ struct kvm_vcpu_para_state {
>  	 * is supposed to work - new host versions will support all old
>  	 * guest API versions.
>  	 */
> -	u32 guest_version;
> -	u32 host_version;
> -	u32 size;
> -	u32 ret;
> +	__u32 guest_version;
> +	__u32 host_version;
> +	__u32 size;
> +	__u32 ret;
>  
>  	/*
>  	 * The address of the vm exit instruction (VMCALL or VMMCALL),
>  	 * which the host will patch according to the CPU model the
>  	 * VM runs on:
>  	 */
> -	u64 hypercall_gpa;
> +	__u64 hypercall_gpa;
>  
>  } __attribute__ ((aligned(PAGE_SIZE)));
> 
> 
> -----
> In simplicity there is elegance.
> Dor Laor ;)
> 
> 
> -------------------------------------------------------------------------
> This SF.net email is sponsored by: Splunk Inc.
> Still grepping through log files to find problems?  Stop.
> Now Search log events and configuration files using AJAX and a browser.
> Download your FREE copy of Splunk now >>  http://get.splunk.com/
> _______________________________________________
> kvm-devel mailing list
> kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
> https://lists.sourceforge.net/lists/listinfo/kvm-devel


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/