From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Vivier Subject: Re: [PATCH 5/5] Call x86_decode_insn() only when needed Date: Wed, 29 Aug 2007 19:03:10 +0200 Message-ID: <46D5A6CE.5090004@bull.net> References: <46D5A2B0.7050802@bull.net> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="------------080206060807060701040305" Cc: kvm-devel To: Laurent Vivier Return-path: In-Reply-To: <46D5A2B0.7050802-6ktuUTfB/bM@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org This is a multi-part message in MIME format. --------------080206060807060701040305 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=ISO-8859-1 Laurent Vivier wrote: > Index: kvm/drivers/kvm/kvm.h > @@ -1860,7 +1869,7 @@ static int kvm_vcpu_ioctl_run(struct kvm > vcpu->mmio_read_completed =3D 1; > vcpu->mmio_needed =3D 0; > r =3D emulate_instruction(vcpu, kvm_run, > - vcpu->mmio_fault_cr2, 0); > + vcpu->mmio_fault_cr2, 0, 0); > if (r =3D=3D EMULATE_DO_MMIO) { > /* > * Read-modify-write. Back to userspace. Sorry this one is wrong, we must have here: + vcpu->mmio_fault_cr2, 0, 1); (good patch attached) Laurent --=20 ------------- Laurent.Vivier-6ktuUTfB/bM@public.gmane.org -------------- "Software is hard" - Donald Knuth --------------080206060807060701040305 Content-Type: text/plain; name="x86_emulate-optimize" Content-Disposition: inline; filename="x86_emulate-optimize" Content-Transfer-Encoding: quoted-printable Index: kvm/drivers/kvm/kvm.h =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- kvm.orig/drivers/kvm/kvm.h 2007-08-29 18:27:21.000000000 +0200 +++ kvm/drivers/kvm/kvm.h 2007-08-29 18:27:26.000000000 +0200 @@ -206,6 +206,8 @@ enum { VCPU_SREG_LDTR, }; =20 +#include "x86_emulate.h" + struct kvm_pio_request { unsigned long count; int cur_count; @@ -372,6 +374,10 @@ struct kvm_vcpu { =20 int cpuid_nent; struct kvm_cpuid_entry cpuid_entries[KVM_MAX_CPUID_ENTRIES]; + + /* emulate context */ + + struct x86_emulate_ctxt emulate_ctxt; }; =20 struct kvm_mem_alias { @@ -525,7 +531,7 @@ enum emulation_result { }; =20 int emulate_instruction(struct kvm_vcpu *vcpu, struct kvm_run *run, - unsigned long cr2, u16 error_code); + unsigned long cr2, u16 error_code, int no_decode); void realmode_lgdt(struct kvm_vcpu *vcpu, u16 size, unsigned long addres= s); void realmode_lidt(struct kvm_vcpu *vcpu, u16 size, unsigned long addres= s); void realmode_lmsw(struct kvm_vcpu *vcpu, unsigned long msw, Index: kvm/drivers/kvm/kvm_main.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- kvm.orig/drivers/kvm/kvm_main.c 2007-08-29 18:27:26.000000000 +0200 +++ kvm/drivers/kvm/kvm_main.c 2007-08-29 18:55:58.000000000 +0200 @@ -1167,47 +1167,56 @@ struct x86_emulate_ops emulate_ops =3D { int emulate_instruction(struct kvm_vcpu *vcpu, struct kvm_run *run, unsigned long cr2, - u16 error_code) + u16 error_code, + int no_decode) { - struct x86_emulate_ctxt emulate_ctxt; int r; - int cs_db, cs_l; =20 vcpu->mmio_fault_cr2 =3D cr2; kvm_arch_ops->cache_regs(vcpu); + vcpu->emulate_ctxt.cr2 =3D cr2; =20 - kvm_arch_ops->get_cs_db_l_bits(vcpu, &cs_db, &cs_l); - - emulate_ctxt.vcpu =3D vcpu; - emulate_ctxt.eflags =3D kvm_arch_ops->get_rflags(vcpu); - emulate_ctxt.cr2 =3D cr2; - emulate_ctxt.mode =3D (emulate_ctxt.eflags & X86_EFLAGS_VM) - ? X86EMUL_MODE_REAL : cs_l - ? X86EMUL_MODE_PROT64 : cs_db - ? X86EMUL_MODE_PROT32 : X86EMUL_MODE_PROT16; - - if (emulate_ctxt.mode =3D=3D X86EMUL_MODE_PROT64) { - emulate_ctxt.cs_base =3D 0; - emulate_ctxt.ds_base =3D 0; - emulate_ctxt.es_base =3D 0; - emulate_ctxt.ss_base =3D 0; - } else { - emulate_ctxt.cs_base =3D get_segment_base(vcpu, VCPU_SREG_CS); - emulate_ctxt.ds_base =3D get_segment_base(vcpu, VCPU_SREG_DS); - emulate_ctxt.es_base =3D get_segment_base(vcpu, VCPU_SREG_ES); - emulate_ctxt.ss_base =3D get_segment_base(vcpu, VCPU_SREG_SS); - } + if (!no_decode) { + int cs_db, cs_l; + kvm_arch_ops->get_cs_db_l_bits(vcpu, &cs_db, &cs_l); + + vcpu->emulate_ctxt.vcpu =3D vcpu; + vcpu->emulate_ctxt.eflags =3D kvm_arch_ops->get_rflags(vcpu); + vcpu->emulate_ctxt.mode =3D + (vcpu->emulate_ctxt.eflags & X86_EFLAGS_VM) + ? X86EMUL_MODE_REAL : cs_l + ? X86EMUL_MODE_PROT64 : cs_db + ? X86EMUL_MODE_PROT32 : X86EMUL_MODE_PROT16; + + if (vcpu->emulate_ctxt.mode =3D=3D X86EMUL_MODE_PROT64) { + vcpu->emulate_ctxt.cs_base =3D 0; + vcpu->emulate_ctxt.ds_base =3D 0; + vcpu->emulate_ctxt.es_base =3D 0; + vcpu->emulate_ctxt.ss_base =3D 0; + } else { + vcpu->emulate_ctxt.cs_base =3D + get_segment_base(vcpu, VCPU_SREG_CS); + vcpu->emulate_ctxt.ds_base =3D + get_segment_base(vcpu, VCPU_SREG_DS); + vcpu->emulate_ctxt.es_base =3D + get_segment_base(vcpu, VCPU_SREG_ES); + vcpu->emulate_ctxt.ss_base =3D + get_segment_base(vcpu, VCPU_SREG_SS); + } =20 - emulate_ctxt.gs_base =3D get_segment_base(vcpu, VCPU_SREG_GS); - emulate_ctxt.fs_base =3D get_segment_base(vcpu, VCPU_SREG_FS); + vcpu->emulate_ctxt.gs_base =3D + get_segment_base(vcpu, VCPU_SREG_GS); + vcpu->emulate_ctxt.fs_base =3D + get_segment_base(vcpu, VCPU_SREG_FS); =20 - r =3D x86_decode_insn(&emulate_ctxt, &emulate_ops); - if (r) - return EMULATE_FAIL; + r =3D x86_decode_insn(&vcpu->emulate_ctxt, &emulate_ops); + if (r) + return EMULATE_FAIL; + } =20 vcpu->mmio_is_write =3D 0; vcpu->pio.string =3D 0; - r =3D x86_emulate_insn(&emulate_ctxt, &emulate_ops); + r =3D x86_emulate_insn(&vcpu->emulate_ctxt, &emulate_ops); if (vcpu->pio.string) return EMULATE_DO_MMIO; =20 @@ -1223,14 +1232,14 @@ int emulate_instruction(struct kvm_vcpu=20 if (kvm_mmu_unprotect_page_virt(vcpu, cr2)) return EMULATE_DONE; if (!vcpu->mmio_needed) { - report_emulation_failure(&emulate_ctxt); + report_emulation_failure(&vcpu->emulate_ctxt); return EMULATE_FAIL; } return EMULATE_DO_MMIO; } =20 kvm_arch_ops->decache_regs(vcpu); - kvm_arch_ops->set_rflags(vcpu, emulate_ctxt.eflags); + kvm_arch_ops->set_rflags(vcpu, vcpu->emulate_ctxt.eflags); =20 if (vcpu->mmio_is_write) { vcpu->mmio_needed =3D 0; @@ -1860,7 +1869,7 @@ static int kvm_vcpu_ioctl_run(struct kvm vcpu->mmio_read_completed =3D 1; vcpu->mmio_needed =3D 0; r =3D emulate_instruction(vcpu, kvm_run, - vcpu->mmio_fault_cr2, 0); + vcpu->mmio_fault_cr2, 0, 1); if (r =3D=3D EMULATE_DO_MMIO) { /* * Read-modify-write. Back to userspace. Index: kvm/drivers/kvm/svm.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- kvm.orig/drivers/kvm/svm.c 2007-08-29 18:27:21.000000000 +0200 +++ kvm/drivers/kvm/svm.c 2007-08-29 18:27:26.000000000 +0200 @@ -938,7 +938,7 @@ static int pf_interception(struct vcpu_s return 1; } er =3D emulate_instruction(&svm->vcpu, kvm_run, fault_address, - error_code); + error_code, 0); mutex_unlock(&kvm->lock); =20 switch (er) { @@ -994,7 +994,8 @@ static int io_interception(struct vcpu_s string =3D (io_info & SVM_IOIO_STR_MASK) !=3D 0; =20 if (string) { - if (emulate_instruction(&svm->vcpu, kvm_run, 0, 0) =3D=3D EMULATE_DO_M= MIO) + if (emulate_instruction(&svm->vcpu, + kvm_run, 0, 0, 0) =3D=3D EMULATE_DO_MMIO) return 0; return 1; } @@ -1052,7 +1053,7 @@ static int cpuid_interception(struct vcp static int emulate_on_interception(struct vcpu_svm *svm, struct kvm_run *kvm_run) { - if (emulate_instruction(&svm->vcpu, NULL, 0, 0) !=3D EMULATE_DONE) + if (emulate_instruction(&svm->vcpu, NULL, 0, 0, 0) !=3D EMULATE_DONE) pr_unimpl(&svm->vcpu, "%s: failed\n", __FUNCTION__); return 1; } Index: kvm/drivers/kvm/vmx.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- kvm.orig/drivers/kvm/vmx.c 2007-08-29 18:27:21.000000000 +0200 +++ kvm/drivers/kvm/vmx.c 2007-08-29 18:27:26.000000000 +0200 @@ -1659,7 +1659,7 @@ static int handle_rmode_exception(struct * Cause the #SS fault with 0 error code in VM86 mode. */ if (((vec =3D=3D GP_VECTOR) || (vec =3D=3D SS_VECTOR)) && err_code =3D=3D= 0) - if (emulate_instruction(vcpu, NULL, 0, 0) =3D=3D EMULATE_DONE) + if (emulate_instruction(vcpu, NULL, 0, 0, 0) =3D=3D EMULATE_DONE) return 1; return 0; } @@ -1715,7 +1715,7 @@ static int handle_exception(struct kvm_v return 1; } =20 - er =3D emulate_instruction(vcpu, kvm_run, cr2, error_code); + er =3D emulate_instruction(vcpu, kvm_run, cr2, error_code, 0); mutex_unlock(&vcpu->kvm->lock); =20 switch (er) { @@ -1776,7 +1776,8 @@ static int handle_io(struct kvm_vcpu *vc string =3D (exit_qualification & 16) !=3D 0; =20 if (string) { - if (emulate_instruction(vcpu, kvm_run, 0, 0) =3D=3D EMULATE_DO_MMIO) + if (emulate_instruction(vcpu, + kvm_run, 0, 0, 0) =3D=3D EMULATE_DO_MMIO) return 0; return 1; } Index: kvm/drivers/kvm/x86_emulate.c =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D --- kvm.orig/drivers/kvm/x86_emulate.c 2007-08-29 18:27:26.000000000 +020= 0 +++ kvm/drivers/kvm/x86_emulate.c 2007-08-29 18:27:26.000000000 +0200 @@ -888,8 +888,12 @@ x86_emulate_insn(struct x86_emulate_ctxt int mode =3D ctxt->mode; int no_wb =3D 0; u64 msr_data; + unsigned long saved_rcx =3D 0, saved_eip =3D 0; unsigned long _eflags =3D ctxt->eflags; =20 + if ((decode->d & ModRM) && (decode->modrm_mod !=3D 3)) + ctxt->cr2 =3D decode->modrm_ea; + if (decode->src.type =3D=3D OP_MEM) { decode->src.ptr =3D (unsigned long *)ctxt->cr2; if ((rc =3D ops->read_emulated((unsigned long)decode->src.ptr, @@ -1274,6 +1278,8 @@ special_insn: ctxt->vcpu->rip =3D decode->eip; goto done; } + saved_rcx =3D ctxt->decode.regs[VCPU_REGS_RCX]; + saved_eip =3D ctxt->decode.eip; decode->regs[VCPU_REGS_RCX]--; decode->eip =3D ctxt->vcpu->rip; } @@ -1289,8 +1295,13 @@ special_insn: ctxt->ds_base, decode->regs[VCPU_REGS_RSI]), &decode->dst.val, - decode->dst.bytes, ctxt->vcpu)) !=3D 0) + decode->dst.bytes, ctxt->vcpu)) !=3D 0) { + if (ctxt->decode.rep_prefix) { + ctxt->decode.regs[VCPU_REGS_RCX] =3D saved_rcx; + ctxt->decode.eip =3D saved_eip; + } goto done; + } register_address_increment(decode->regs[VCPU_REGS_RSI], (_eflags & EFLG_DF) ? -decode->dst.bytes : decode->dst.bytes); @@ -1316,8 +1327,13 @@ special_insn: decode->dst.ptr =3D (unsigned long *)&decode->regs[VCPU_REGS_RAX]; if ((rc =3D ops->read_emulated(ctxt->cr2, &decode->dst.val, decode->dst.bytes, - ctxt->vcpu)) !=3D 0) + ctxt->vcpu)) !=3D 0) { + if (ctxt->decode.rep_prefix) { + ctxt->decode.regs[VCPU_REGS_RCX] =3D saved_rcx; + ctxt->decode.eip =3D saved_eip; + } goto done; + } register_address_increment(decode->regs[VCPU_REGS_RSI], (_eflags & EFLG_DF) ? -decode->dst.bytes : decode->dst.bytes); @@ -1338,8 +1354,13 @@ special_insn: pop_instruction: if ((rc =3D ops->read_std(register_address(ctxt->ss_base, decode->regs[VCPU_REGS_RSP]), decode->dst.ptr, - decode->op_bytes, ctxt->vcpu)) !=3D 0) + decode->op_bytes, ctxt->vcpu)) !=3D 0) { + if (ctxt->decode.rep_prefix) { + ctxt->decode.regs[VCPU_REGS_RCX] =3D saved_rcx; + ctxt->decode.eip =3D saved_eip; + } goto done; + } =20 register_address_increment(decode->regs[VCPU_REGS_RSP], decode->op_bytes); --------------080206060807060701040305 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/ --------------080206060807060701040305 Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kvm-devel mailing list kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org https://lists.sourceforge.net/lists/listinfo/kvm-devel --------------080206060807060701040305--