From: Cam Macdonell <cam-edFDblaTWIyXbbII50Afww@public.gmane.org>
To: Dor Laor <dor.laor-atKUWr5tajBWk0Htik3J/w@public.gmane.org>
Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org
Subject: Re: VirtIO configure and compilation problems
Date: Tue, 04 Sep 2007 07:42:22 -0600 [thread overview]
Message-ID: <46DD60BE.5090900@cs.ualberta.ca> (raw)
In-Reply-To: <64F9B87B6B770947A9F8391472E032160D70662C-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
Hi Dor,
Dor Laor wrote:
>>
>> the following files:
>> linux/virtio.h
>> linux/virtio_blk.h
>> linux/virtio_net.h
>
> The above files are currently part of the guest kernel (not modules) so
> they shouldn't be copied. Instead you should compile the whole kernel
> and
> use it for the guest. I'll soon make modules out of them for better
> usability.
>
But, correct if I'm wrong, they still need be copied (some how) into
kvm-userspace
build as it requires them.
Also to be clear, do I use the standard kvm host modules then? Should I
specify that
kernel directory when I run "make -C kernel..."?
>> asm-x86_64/hypercall.h
>
> I'll add it to the sync entry.
> 10x
>
>> don't get copied into kvm-userspace/kernel/include
>>
>> after copying them manually, I get the compile to move forward until
>> this happens:
>>
>> CC [M] /home/cam/research/KVM/dor/kvm-
>> userspace/kernel/virtio_backend.o
>> KVM/dor/kvm-userspace/kernel/virtio_backend.c: In function
>> 'virtio_add_buf':
>> KVM/dor/kvm-userspace/kernel/virtio_backend.c:104: warning: parameter
>> names (without types) in function declaration
>> KVM/dor/kvm-userspace/kernel/virtio_backend.c:131: error: 'prev'
>> undeclared (first use in this function)
>> KVM/dor/kvm-userspace/kernel/virtio_backend.c:131: error: (Each
>> undeclared identifier is reported only once
>> KVM/dor/kvm-userspace/kernel/virtio_backend.c:131: error: for each
>> function it appears in.)
>> make[3]: *** [KVM/dor/kvm-userspace/kernel/virtio_backend.o] Error 1
>>
>> Hopefully I'll get to a point when I can fix these myself, but I'm not
>> there yet :)
>
> Did it happen after you passed all virtio*.h to kernel/include/linux?
> Strange, seems like uninitialized_var(prev) is not good?
>
Yes, I looked at the code and it seems that a definition of 'prev' is
simply missing.
Thanks for your help,
Cam
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
next prev parent reply other threads:[~2007-09-04 13:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <AcfmraaesoemPSOZSEeX8bLIYrKo5w==>
2007-08-25 0:19 ` [RFC][PATCH 5/6][KVM VIRTIO] Add the network device code Dor Laor
[not found] ` <64F9B87B6B770947A9F8391472E032160D59005E-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2007-08-27 12:22 ` Christian Borntraeger
[not found] ` <200708271422.54306.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-08-29 6:46 ` Dor Laor
[not found] ` <64F9B87B6B770947A9F8391472E032160D6558CB-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2007-08-29 15:26 ` Cam Macdonell
[not found] ` <46D59029.5080403-edFDblaTWIyXbbII50Afww@public.gmane.org>
2007-08-29 15:36 ` Luca
[not found] ` <68676e00708290836n375c7501o727ec1cc2b998865-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-29 17:11 ` Cam Macdonell
[not found] ` <46D5A8C9.10408-edFDblaTWIyXbbII50Afww@public.gmane.org>
2007-08-29 17:18 ` Luca
[not found] ` <68676e00708291018t1262e97dg14b9a4278ae0d91e-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-09-03 14:00 ` Cam Macdonell
2007-09-09 12:56 ` Avi Kivity
[not found] ` <200708291223.51252.borntraeger@de.ibm.com>
[not found] ` <200708291223.51252.borntraeger-tA70FqPdS9bQT0dZR+AlfA@public.gmane.org>
2007-09-03 14:23 ` git branch of Virtio implementation for KVM Dor Laor
[not found] ` <64F9B87B6B770947A9F8391472E032160D70643B-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2007-09-03 21:28 ` VirtIO configure and compilation problems Cam Macdonell
[not found] ` <46DC7C84.1080708-edFDblaTWIyXbbII50Afww@public.gmane.org>
2007-09-04 8:59 ` Dor Laor
[not found] ` <64F9B87B6B770947A9F8391472E032160D70662C-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2007-09-04 13:42 ` Cam Macdonell [this message]
[not found] ` <68676e00708281252m64116588q996e1d2079632cfd@mail.gmail.com>
[not found] ` <68676e00708281252m64116588q996e1d2079632cfd-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2007-08-29 6:40 ` [RFC][PATCH 5/6][KVM VIRTIO] Add the network device code Dor Laor
[not found] ` <64F9B87B6B770947A9F8391472E032160D6558C3-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org>
2007-08-30 23:08 ` Anthony Liguori
2007-09-09 12:58 ` Avi Kivity
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=46DD60BE.5090900@cs.ualberta.ca \
--to=cam-edfdblatwiyxbbii50afww@public.gmane.org \
--cc=dor.laor-atKUWr5tajBWk0Htik3J/w@public.gmane.org \
--cc=kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox