From mboxrd@z Thu Jan 1 00:00:00 1970 From: Cam Macdonell Subject: Re: VirtIO configure and compilation problems Date: Tue, 04 Sep 2007 07:42:22 -0600 Message-ID: <46DD60BE.5090900@cs.ualberta.ca> References: <64F9B87B6B770947A9F8391472E032160D59005E@ehost011-8.exch011.intermedia.net> <200708271422.54306.borntraeger@de.ibm.com> <64F9B87B6B770947A9F8391472E032160D6558CB@ehost011-8.exch011.intermedia.net> <200708291223.51252.borntraeger@de.ibm.com> <64F9B87B6B770947A9F8391472E032160D70643B@ehost011-8.exch011.intermedia.net> <46DC7C84.1080708@cs.ualberta.ca> <64F9B87B6B770947A9F8391472E032160D70662C@ehost011-8.exch011.intermedia.net> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org To: Dor Laor Return-path: In-Reply-To: <64F9B87B6B770947A9F8391472E032160D70662C-yEcIvxbTEBqsx+V+t5oei8rau4O3wl8o3fe8/T/H7NteoWH0uzbU5w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Hi Dor, Dor Laor wrote: >> >> the following files: >> linux/virtio.h >> linux/virtio_blk.h >> linux/virtio_net.h > > The above files are currently part of the guest kernel (not modules) so > they shouldn't be copied. Instead you should compile the whole kernel > and > use it for the guest. I'll soon make modules out of them for better > usability. > But, correct if I'm wrong, they still need be copied (some how) into kvm-userspace build as it requires them. Also to be clear, do I use the standard kvm host modules then? Should I specify that kernel directory when I run "make -C kernel..."? >> asm-x86_64/hypercall.h > > I'll add it to the sync entry. > 10x > >> don't get copied into kvm-userspace/kernel/include >> >> after copying them manually, I get the compile to move forward until >> this happens: >> >> CC [M] /home/cam/research/KVM/dor/kvm- >> userspace/kernel/virtio_backend.o >> KVM/dor/kvm-userspace/kernel/virtio_backend.c: In function >> 'virtio_add_buf': >> KVM/dor/kvm-userspace/kernel/virtio_backend.c:104: warning: parameter >> names (without types) in function declaration >> KVM/dor/kvm-userspace/kernel/virtio_backend.c:131: error: 'prev' >> undeclared (first use in this function) >> KVM/dor/kvm-userspace/kernel/virtio_backend.c:131: error: (Each >> undeclared identifier is reported only once >> KVM/dor/kvm-userspace/kernel/virtio_backend.c:131: error: for each >> function it appears in.) >> make[3]: *** [KVM/dor/kvm-userspace/kernel/virtio_backend.o] Error 1 >> >> Hopefully I'll get to a point when I can fix these myself, but I'm not >> there yet :) > > Did it happen after you passed all virtio*.h to kernel/include/linux? > Strange, seems like uninitialized_var(prev) is not good? > Yes, I looked at the code and it seems that a definition of 'prev' is simply missing. Thanks for your help, Cam ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/