From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 1/5] Clean up unloved invlpg: remove kvm_arch_ops.invlpg and tweak emulator. Date: Wed, 05 Sep 2007 18:30:47 +0300 Message-ID: <46DECBA7.7020905@qumranet.com> References: <1189005567.10802.127.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Rusty Russell Return-path: In-Reply-To: <1189005567.10802.127.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Rusty Russell wrote: > invlpg shouldn't fetch the "src" address, since it may not be valid, > however SVM's "solution" which neuters emulation of all group 7 > instruction is horrible and breaks kvm-lite. The simplest fix is to > put a special check in for invlpg. > > Also, remove the unused invlpg member of struct kvm_arch_ops. > > One change, one patch. We'll want to revert the invlpg removal in the future anyway, when/if we begin to track virtual addresses in the shadow cache. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/