Re: [PATCH 4/5] kvm-lite: "The Unbearable Liteness"

[Avi Kivity <avi-atKUWr5tajBWk0Htik3J/w@public.gmane.org>]

Rusty Russell wrote:
> This patch is not for serious application, but makes interesting
> reading.  Requires Anthony's new hypercall patches.
>
> Comments:
>
> 2) Includes proposed "platform_type" extension for boot protocol.  May not be
>    necessary.
> 3) kvm/ now contains guest code, so needs to be obj-y.
>   

We'll want the guest code in a different patch for easier review.

> 5) Changes emulator not to try to restore regs after inject_gp.  May refactor
>    (we need to deal with this for inject_pf anyway).
>   

Separate please.

Eventually we'll want kvm_arch_ops (to be renamed kvm_x86_ops) to be a 
member of 'struct kvm', so lite and dark guests can coexist.  That's not 
a precondition to merging, however.

 From a cursory glance, all's well.  I'll do a detailed review later on.


-- 
Any sufficiently difficult bug is indistinguishable from a feature.


-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >>  http://get.splunk.com/