From mboxrd@z Thu Jan 1 00:00:00 1970 From: Avi Kivity Subject: Re: [PATCH 4/5] kvm-lite: "The Unbearable Liteness" Date: Wed, 05 Sep 2007 20:02:58 +0300 Message-ID: <46DEE142.3060501@qumranet.com> References: <1189005567.10802.127.camel@localhost.localdomain> <1189005638.10802.129.camel@localhost.localdomain> <1189005692.10802.132.camel@localhost.localdomain> <1189006973.10802.140.camel@localhost.localdomain> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Cc: kvm-devel To: Rusty Russell Return-path: In-Reply-To: <1189006973.10802.140.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org Errors-To: kvm-devel-bounces-5NWGOfrQmneRv+LV9MX5uipxlwaOVQ5f@public.gmane.org List-Id: kvm.vger.kernel.org Rusty Russell wrote: > This patch is not for serious application, but makes interesting > reading. Requires Anthony's new hypercall patches. > > Comments: > > 2) Includes proposed "platform_type" extension for boot protocol. May not be > necessary. > 3) kvm/ now contains guest code, so needs to be obj-y. > We'll want the guest code in a different patch for easier review. > 5) Changes emulator not to try to restore regs after inject_gp. May refactor > (we need to deal with this for inject_pf anyway). > Separate please. Eventually we'll want kvm_arch_ops (to be renamed kvm_x86_ops) to be a member of 'struct kvm', so lite and dark guests can coexist. That's not a precondition to merging, however. From a cursory glance, all's well. I'll do a detailed review later on. -- Any sufficiently difficult bug is indistinguishable from a feature. ------------------------------------------------------------------------- This SF.net email is sponsored by: Splunk Inc. Still grepping through log files to find problems? Stop. Now Search log events and configuration files using AJAX and a browser. Download your FREE copy of Splunk now >> http://get.splunk.com/